[SPARK-47965][CORE] Avoid orNull in TypedConfigBuilder and OptionalConfigEntry #46197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
changed the title
HyukjinKwon
force-pushed
the
SPARK-47965
branch
from
9f6632d
to
1941b66
Compare
zhengruifeng
approved these changes
Apr 24, 2024
| @@ -196,12 +196,6 @@ class ConfigEntrySuite extends SparkFunSuite { | |||
| assert(conversionError.getMessage === s"${conversionTest.key} should be double, but was abc") | |||
| } | |||
|
|
|||
| test("default value handling is null-safe") { | |||
There was a problem hiding this comment.
Given that we have a test coverage, it seems that we remove a valid use case, @HyukjinKwon .
dongjoon-hyun
approved these changes
Apr 24, 2024
|
yeah, it should not be a breaking change I believe. I checked the configuration related interface, and we don't allow setting |
HyukjinKwon
force-pushed
the
SPARK-47965
branch
from
f3a6d1e
to
2a253a8
Compare
|
Merged to master. |
HyukjinKwon
added a commit
that referenced
this pull request
May 8, 2024
…ptionalConfigEntry` ### What changes were proposed in this pull request? This PR partially reverts #46197 because of the behaviour change below: ```python >>> spark.conf.get("spark.sql.optimizer.excludedRules") '<undefined>' ``` ### Why are the changes needed? To avoid behaviour change. ### Does this PR introduce _any_ user-facing change? No, the main change has not been released out yet. ### How was this patch tested? Manually as described above. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46472 from HyukjinKwon/SPARK-47965-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…nfigEntry ### What changes were proposed in this pull request? This PR proposes to avoid orNull in `TypedConfigBuilder`. Keys and values cannot be set `null` anyway, see `RuntimeConfig` and `SparkConf`. Also, uses `ConfigEntry.UNDEFINED` in `OptionalConfigEntry` instead of `null`. ### Why are the changes needed? For code cleanup. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI in this PR should verify them. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46197 from HyukjinKwon/SPARK-47965. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…ptionalConfigEntry` ### What changes were proposed in this pull request? This PR partially reverts apache#46197 because of the behaviour change below: ```python >>> spark.conf.get("spark.sql.optimizer.excludedRules") '<undefined>' ``` ### Why are the changes needed? To avoid behaviour change. ### Does this PR introduce _any_ user-facing change? No, the main change has not been released out yet. ### How was this patch tested? Manually as described above. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46472 from HyukjinKwon/SPARK-47965-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to avoid orNull in
TypedConfigBuilder. Keys and values cannot be setnullanyway, seeRuntimeConfigandSparkConf.Also, uses
ConfigEntry.UNDEFINEDinOptionalConfigEntryinstead ofnull.Why are the changes needed?
For code cleanup.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI in this PR should verify them.
Was this patch authored or co-authored using generative AI tooling?
No.