Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-47933][CONNECT][PYTHON][FOLLOW-UP] Avoid referencing _to_seq in pyspark-connect #46229

Closed

Conversation

HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR is a followup of #46155 that removes the reference of _to_seq that pyspark-connect package does not have.

Why are the changes needed?

To recover the CI https://github.com/apache/spark/actions/runs/8821919392/job/24218893631

Does this PR introduce any user-facing change?

No, the main change has not been released out yet.

How was this patch tested?

Manually tested.

Was this patch authored or co-authored using generative AI tooling?

No.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (Pending CIs)

@dongjoon-hyun
Copy link
Member

Merged to master.

HyukjinKwon added a commit that referenced this pull request Apr 30, 2024
… classes

### What changes were proposed in this pull request?

This PR proposes to fix `pyspark-connect` build that is broken by #46155. It is similar with the followups such as #46229 and #46262 but make sure the tests pass within this PR.

### Why are the changes needed?

To recover the CI https://github.com/apache/spark/actions/runs/8884003967

### Does this PR introduce _any_ user-facing change?

No, the main change has not been released yet.

### How was this patch tested?

CI in my own fork: https://github.com/HyukjinKwon/spark/actions/runs/8889698252/job/24408487227

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #46294 from HyukjinKwon/SPARK-48052.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
JacobZheng0927 pushed a commit to JacobZheng0927/spark that referenced this pull request May 11, 2024
…n `pyspark-connect`

### What changes were proposed in this pull request?

This PR is a followup of apache#46155 that removes the reference of `_to_seq` that `pyspark-connect` package does not have.

### Why are the changes needed?

To recover the CI https://github.com/apache/spark/actions/runs/8821919392/job/24218893631

### Does this PR introduce _any_ user-facing change?

No, the main change has not been released out yet.

### How was this patch tested?

Manually tested.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#46229 from HyukjinKwon/SPARK-47933-followuptmp.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
JacobZheng0927 pushed a commit to JacobZheng0927/spark that referenced this pull request May 11, 2024
… classes

### What changes were proposed in this pull request?

This PR proposes to fix `pyspark-connect` build that is broken by apache#46155. It is similar with the followups such as apache#46229 and apache#46262 but make sure the tests pass within this PR.

### Why are the changes needed?

To recover the CI https://github.com/apache/spark/actions/runs/8884003967

### Does this PR introduce _any_ user-facing change?

No, the main change has not been released yet.

### How was this patch tested?

CI in my own fork: https://github.com/HyukjinKwon/spark/actions/runs/8889698252/job/24408487227

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#46294 from HyukjinKwon/SPARK-48052.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants