[SPARK-47994][SQL] Fix bug with CASE WHEN column filter push down in SQLServer #46231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urosstan-db
approved these changes
Apr 25, 2024
|
cc @beliefer FYI |
milastdbx
approved these changes
Apr 26, 2024
|
cc @yaooqinn |
yaooqinn
reviewed
Apr 29, 2024
sql/core/src/main/scala/org/apache/spark/sql/jdbc/MsSqlServerDialect.scala
Outdated
Show resolved
Hide resolved
yaooqinn
reviewed
Apr 29, 2024
sql/core/src/main/scala/org/apache/spark/sql/jdbc/MsSqlServerDialect.scala
Outdated
Show resolved
Hide resolved
yaooqinn
approved these changes
Apr 29, 2024
|
LGTM |
|
Thank you @stefanbuk-db Merged to master |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…SQLServer ### What changes were proposed in this pull request? In this PR I propose a change in QueryBuilder for SQLServer. This change modifies push down of predicate that contains a column that is generated with a CASE WHEN construct, so that we add simple ` = 1` comparison to this query, making it work on SQLServer. ### Why are the changes needed? SQLServer does not support 0 or 1 as a boolean values. There are certain situations where spark optimizer rewrites filters that contain CASE WHEN columns in a way that adds 1 or 0 as a boolean values, which fails on SQLServer side with an error "An expression of non-boolean type specified in a context where a condition is expected". With these changes, we modify pushing this filters down, and error is no longer present. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? A new test case is added, which fails without these changes. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#46231 from stefanbuk-db/SQLServer_case_when_bugfix. Authored-by: Stefan Bukorovic <stefan.bukorovic@databricks.com> Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In this PR I propose a change in QueryBuilder for SQLServer. This change modifies push down of predicate that contains a column that is generated with a CASE WHEN construct, so that we add simple
= 1comparison to this query, making it work on SQLServer.Why are the changes needed?
SQLServer does not support 0 or 1 as a boolean values. There are certain situations where spark optimizer rewrites filters that contain CASE WHEN columns in a way that adds 1 or 0 as a boolean values, which fails on SQLServer side with an error "An expression of non-boolean type specified in a context where a condition is expected". With these changes, we modify pushing this filters down, and error is no longer present.
Does this PR introduce any user-facing change?
No
How was this patch tested?
A new test case is added, which fails without these changes.
Was this patch authored or co-authored using generative AI tooling?
No