[SPARK-48004][SQL] Add WriteFilesExecBase trait for v1 write #46240
+21
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan @yaooqinn thank you |
yaooqinn
approved these changes
Apr 26, 2024
|
Thanks, merged to master |
|
late LGTM |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
### What changes were proposed in this pull request? This pr adds a new trait `WriteFilesExecBase` for v1 write, so that the downstream project can inherit `WriteFilesExecBase` rather than `WriteFilesExec`. The reason is that, inherit a `case class` is a bad practice in scala world. ### Why are the changes needed? Make downstream project easy to develop. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? Pass CI ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#46240 from ulysses-you/WriteFilesExecBase. Authored-by: ulysses-you <ulyssesyou18@gmail.com> Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr adds a new trait
WriteFilesExecBasefor v1 write, so that the downstream project can inheritWriteFilesExecBaserather thanWriteFilesExec. The reason is that, inherit acase classis a bad practice in scala world.Why are the changes needed?
Make downstream project easy to develop.
Does this PR introduce any user-facing change?
no
How was this patch tested?
Pass CI
Was this patch authored or co-authored using generative AI tooling?
no