[SPARK-48021][ML][BUILD][FOLLOWUP] add --add-modules=jdk.incubator.vector to maven compile args
#46259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @LuciferYang |
|
Yes, we should keep |
yaooqinn
approved these changes
Apr 28, 2024
|
We can manually verify it through Maven test Before
there is a WARNING message: After
no WARNING message related to |
Yeah |
|
Merged into master for Spark 4.0. Thanks @panbingkun and @yaooqinn |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…ector` to maven compile args ### What changes were proposed in this pull request? The pr is following up apache#46246 The pr aims to add `--add-modules=jdk.incubator.vector` to maven `compile args`. ### Why are the changes needed? As commented by LuciferYang , we need to be consistent in `maven` compile. apache#46246 (comment) <img width="907" alt="image" src="https://github.com/apache/spark/assets/15246973/26163da2-f27d-4ec2-893f-d9282b68aec1"> ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46259 from panbingkun/SPARK-48021. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: yangjie01 <yangjie01@baidu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr is following up #46246
The pr aims to add
--add-modules=jdk.incubator.vectorto mavencompile args.Why are the changes needed?
As commented by @LuciferYang , we need to be consistent in
mavencompile.#46246 (comment)
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.