[SPARK-46009][SQL][FOLLOWUP] Remove unused PERCENTILE_CONT and PERCENTILE_DISC in g4 #46272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaooqinn
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Oh, could you fix this, @beliefer ?
[info] *** 2 TESTS FAILED ***
[error] Failed: Total 7391, Failed 2, Errors 0, Passed 7389, Ignored 5
[error] Failed tests:
[error] org.apache.spark.sql.catalyst.SQLKeywordSuite
[error] (catalyst / Test / test) sbt.TestsFailedException: Tests unsuccessful
HyukjinKwon
approved these changes
Apr 29, 2024
beliefer
force-pushed
the
SPARK-46009_followup2
branch
from
6629199
to
83664b1
Compare
There was a problem hiding this comment.
It seems that we have more failures still, @beliefer . Could you take a look at all of them?
|
Gentle ping, @beliefer . |
beliefer
force-pushed
the
SPARK-46009_followup2
branch
from
83664b1
to
cc5ce4f
Compare
|
@dongjoon-hyun I'm a bit busy. Thank you for ping me. |
|
Thank you, @beliefer . |
|
@dongjoon-hyun @HyukjinKwon @yaooqinn Thank you! |
dongjoon-hyun
pushed a commit
that referenced
this pull request
May 4, 2024
### What changes were proposed in this pull request? This PR propose to remove unused golden file. ### Why are the changes needed? #46272 removed unused `PERCENTILE_CONT` and `PERCENTILE_DISC` in g4. But I made a mistake and submitted my local test code. ### Does this PR introduce _any_ user-facing change? 'No'. ### How was this patch tested? GA ### Was this patch authored or co-authored using generative AI tooling? 'No'. Closes #46385 from beliefer/SPARK-46009_followup3. Authored-by: beliefer <beliefer@163.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
sinaiamonkar-sai
pushed a commit
to sinaiamonkar-sai/spark
that referenced
this pull request
May 5, 2024
### What changes were proposed in this pull request? This PR propose to remove unused golden file. ### Why are the changes needed? apache#46272 removed unused `PERCENTILE_CONT` and `PERCENTILE_DISC` in g4. But I made a mistake and submitted my local test code. ### Does this PR introduce _any_ user-facing change? 'No'. ### How was this patch tested? GA ### Was this patch authored or co-authored using generative AI tooling? 'No'. Closes apache#46385 from beliefer/SPARK-46009_followup3. Authored-by: beliefer <beliefer@163.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…TILE_DISC in g4 ### What changes were proposed in this pull request? This PR propose to remove unused `PERCENTILE_CONT` and `PERCENTILE_DISC` in g4 ### Why are the changes needed? apache#43910 merged the parse rule of `PercentileCont` and `PercentileDisc` into `functionCall`, but forgot to remove unused `PERCENTILE_CONT` and `PERCENTILE_DISC` in g4. ### Does this PR introduce _any_ user-facing change? 'No'. ### How was this patch tested? GA. ### Was this patch authored or co-authored using generative AI tooling? 'No'. Closes apache#46272 from beliefer/SPARK-46009_followup2. Authored-by: beliefer <beliefer@163.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
### What changes were proposed in this pull request? This PR propose to remove unused golden file. ### Why are the changes needed? apache#46272 removed unused `PERCENTILE_CONT` and `PERCENTILE_DISC` in g4. But I made a mistake and submitted my local test code. ### Does this PR introduce _any_ user-facing change? 'No'. ### How was this patch tested? GA ### Was this patch authored or co-authored using generative AI tooling? 'No'. Closes apache#46385 from beliefer/SPARK-46009_followup3. Authored-by: beliefer <beliefer@163.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR propose to remove unused
PERCENTILE_CONTandPERCENTILE_DISCin g4Why are the changes needed?
#43910 merged the parse rule of
PercentileContandPercentileDiscintofunctionCall, but forgot to remove unusedPERCENTILE_CONTandPERCENTILE_DISCin g4.Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
GA.
Was this patch authored or co-authored using generative AI tooling?
'No'.