[SPARK-48044][PYTHON][CONNECT] Cache DataFrame.isStreaming
#46281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged to master. Thank you, @zhengruifeng . |
|
thanks @dongjoon-hyun for reviews |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
### What changes were proposed in this pull request? Cache `DataFrame.isStreaming` ### Why are the changes needed? In PS, `DataFrame.isStreaming` is used in the construction of `InternalFrame` https://github.com/apache/spark/blob/e01ac581f46aa595e66daf33fe92b56d1328bc78/python/pyspark/pandas/internal.py#L624 it might cause performance issues since a lot of `InternalFrame` will be built even in a simple logic, such as ``` import cProfile, pstats import pyspark.pandas as ps df1 = ps.DataFrame({'lkey': ['foo', 'bar', 'baz', 'foo'], 'value': [1, 2, 3, 5]}, columns=['lkey', 'value']) cProfile.run("df1['value2'] = df1['value'] + 123 + 456", "/tmp/profile_results") pstats.Stats("/tmp/profile_results").sort_stats("cumtime").print_stats(.1) ``` before: ``` ncalls tottime percall cumtime percall filename:lineno(function) 1 0.000 0.000 0.120 0.120 {built-in method builtins.exec} 1 0.000 0.000 0.120 0.120 <string>:1(<module>) 27 0.000 0.000 0.113 0.004 /Users/ruifeng.zheng/Dev/spark/python/pyspark/sql/connect/client/core.py:1160(_analyze) 27 0.000 0.000 0.112 0.004 /Users/ruifeng.zheng/.dev/miniconda3/envs/spark_dev_311/lib/python3.11/site-packages/grpc/_channel.py:1161(__call__) 27 0.000 0.000 0.112 0.004 /Users/ruifeng.zheng/.dev/miniconda3/envs/spark_dev_311/lib/python3.11/site-packages/grpc/_channel.py:1124(_blocking) 27 0.110 0.004 0.110 0.004 {method 'next_event' of 'grpc._cython.cygrpc.SegregatedCall' objects} 2 0.000 0.000 0.108 0.054 /Users/ruifeng.zheng/Dev/spark/python/pyspark/pandas/base.py:318(__add__) 2 0.000 0.000 0.078 0.039 /Users/ruifeng.zheng/Dev/spark/python/pyspark/pandas/data_type_ops/num_ops.py:79(add) 2 0.000 0.000 0.074 0.037 /Users/ruifeng.zheng/Dev/spark/python/pyspark/pandas/base.py:210(wrapper) 24 0.000 0.000 0.064 0.003 /Users/ruifeng.zheng/Dev/spark/python/pyspark/pandas/internal.py:1435(copy) 24 0.000 0.000 0.063 0.003 /Users/ruifeng.zheng/Dev/spark/python/pyspark/pandas/internal.py:535(__init__) ``` after: ``` ncalls tottime percall cumtime percall filename:lineno(function) 1 0.000 0.000 0.082 0.082 {built-in method builtins.exec} 1 0.000 0.000 0.082 0.082 <string>:1(<module>) 2 0.000 0.000 0.081 0.041 /Users/ruifeng.zheng/Dev/spark/python/pyspark/pandas/base.py:318(__add__) 4 0.000 0.000 0.078 0.019 /Users/ruifeng.zheng/Dev/spark/python/pyspark/sql/connect/client/core.py:1160(_analyze) 4 0.000 0.000 0.077 0.019 /Users/ruifeng.zheng/.dev/miniconda3/envs/spark_dev_311/lib/python3.11/site-packages/grpc/_channel.py:1161(__call__) 4 0.000 0.000 0.077 0.019 /Users/ruifeng.zheng/.dev/miniconda3/envs/spark_dev_311/lib/python3.11/site-packages/grpc/_channel.py:1124(_blocking) 4 0.077 0.019 0.077 0.019 {method 'next_event' of 'grpc._cython.cygrpc.SegregatedCall' objects} 26 0.000 0.000 0.058 0.002 /Users/ruifeng.zheng/Dev/spark/python/pyspark/sql/connect/dataframe.py:1783(schema) 3 0.000 0.000 0.058 0.019 /Users/ruifeng.zheng/Dev/spark/python/pyspark/sql/connect/client/core.py:1031(schema) 2 0.000 0.000 0.057 0.029 /Users/ruifeng.zheng/Dev/spark/python/pyspark/pandas/data_type_ops/num_ops.py:79(add) 2 0.000 0.000 0.057 0.028 /Users/ruifeng.zheng/Dev/spark/python/pyspark/pandas/base.py:210(wrapper) 24 0.000 0.000 0.026 0.001 /Users/ruifeng.zheng/Dev/spark/python/pyspark/pandas/internal.py:1435(copy) 21 0.000 0.000 0.025 0.001 /Users/ruifeng.zheng/Dev/spark/python/pyspark/pandas/internal.py:1419(select_column) 19 0.000 0.000 0.025 0.001 /Users/ruifeng.zheng/Dev/spark/python/pyspark/pandas/series.py:438(_internal) 24 0.000 0.000 0.025 0.001 /Users/ruifeng.zheng/Dev/spark/python/pyspark/pandas/internal.py:535(__init__) ``` There are 24 `InternalFrame.__init__` invocations in this example, the number of RPC is reduced from 27 to 4. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? ci ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#46281 from zhengruifeng/cache_is_streaming_x. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Cache
DataFrame.isStreamingWhy are the changes needed?
In PS,
DataFrame.isStreamingis used in the construction ofInternalFramespark/python/pyspark/pandas/internal.py
Line 624 in e01ac58
it might cause performance issues since a lot of
InternalFramewill be built even in a simple logic, such asbefore:
after:
There are 24
InternalFrame.__init__invocations in this example, the number of RPC is reduced from 27 to 4.Does this PR introduce any user-facing change?
no
How was this patch tested?
ci
Was this patch authored or co-authored using generative AI tooling?
no