[SPARK-48061][SQL][TESTS] Parameterize max limits of spark.sql.test.randomDataGenerator
#46305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…randomDataGenerator`
|
Hi, @viirya . Could you review this PR, please? |
viirya
approved these changes
Apr 30, 2024
|
Thank you, @viirya ! Since this is irrelevant to CI and I did manual verification. I'll merge this~ Merged to master for Apache Spark 4.0.0. |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…randomDataGenerator` ### What changes were proposed in this pull request? This PR aims to parameterize `MAX_ARR_SIZE`, `MAX_MAP_SIZE`, and `MAX_STR_LEN` of `spark.sql.test.randomDataGenerator` by supporting. - `spark.sql.test.randomDataGenerator.maxArraySize` - `spark.sql.test.randomDataGenerator.maxMapSize` - `spark.sql.test.randomDataGenerator.maxStrLen` ### Why are the changes needed? Apache Spark already has the code which needs these parameters. We had better support these to allow the developers to use them without changing and recompiling the source code. https://github.com/apache/spark/blob/0329479acb6758c4d3e53d514ea832a181d31065/sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingQueryHashPartitionVerifySuite.scala#L155-L156 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual. **BEFORE (golden file size: `269M`)** ``` $ SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *StreamingQueryHashPartitionVerifySuite" $ ls -alh ./sql/core/target/scala-2.13/test-classes/structured-streaming/partition-tests/rowsAndPartIds -rw-r--r-- 1 dongjoon staff 269M Apr 30 09:55 ./sql/core/target/scala-2.13/test-classes/structured-streaming/partition-tests/rowsAndPartIds ``` **AFTER (golden file size: `5.8M`)** ``` $ SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *StreamingQueryHashPartitionVerifySuite" \ -Dspark.sql.test.randomDataGenerator.maxStrLen=100 \ -Dspark.sql.test.randomDataGenerator.maxArraySize=4 $ ls -alh ./sql/core/target/scala-2.13/test-classes/structured-streaming/partition-tests/rowsAndPartIds -rw-r--r-- 1 dongjoon staff 5.8M Apr 30 09:56 ./sql/core/target/scala-2.13/test-classes/structured-streaming/partition-tests/rowsAndPartIds ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46305 from dongjoon-hyun/SPARK-48061. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to parameterize
MAX_ARR_SIZE,MAX_MAP_SIZE, andMAX_STR_LENofspark.sql.test.randomDataGeneratorby supporting.spark.sql.test.randomDataGenerator.maxArraySizespark.sql.test.randomDataGenerator.maxMapSizespark.sql.test.randomDataGenerator.maxStrLenWhy are the changes needed?
Apache Spark already has the code which needs these parameters. We had better support these to allow the developers to use them without changing and recompiling the source code.
spark/sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingQueryHashPartitionVerifySuite.scala
Lines 155 to 156 in 0329479
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual.
BEFORE (golden file size:
269M)AFTER (golden file size:
5.8M)Was this patch authored or co-authored using generative AI tooling?
No.