[SPARK-48063][CORE] Enable spark.stage.ignoreDecommissionFetchFailure by default
#46308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
force-pushed
the
SPARK-48063
branch
from
0c4cd98
to
dba6fab
Compare
dongjoon-hyun
force-pushed
the
SPARK-48063
branch
from
dba6fab
to
2215889
Compare
|
Could you review this when you have some time, @huaxingao ? |
huaxingao
approved these changes
Apr 30, 2024
|
Thank you, @huaxingao ! |
|
Merged to master for Apache Spark 4.0.0. |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…e` by default ### What changes were proposed in this pull request? This PR aims to **enable `spark.stage.ignoreDecommissionFetchFailure` by default** while keeping `spark.scheduler.maxRetainedRemovedDecommissionExecutors=0` without any change for Apache Spark 4.0.0 in order to help a user use this feature more easily by setting only one configuration, `spark.scheduler.maxRetainedRemovedDecommissionExecutors`. ### Why are the changes needed? This feature was added at Apache Spark 3.4.0 via SPARK-40481 and SPARK-40979 and has been used for two years to support executor decommissioning features in the production. - apache#37924 - apache#38441 ### Does this PR introduce _any_ user-facing change? No because `spark.scheduler.maxRetainedRemovedDecommissionExecutors` is still `0`. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46308 from dongjoon-hyun/SPARK-48063. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to enable
spark.stage.ignoreDecommissionFetchFailureby default while keepingspark.scheduler.maxRetainedRemovedDecommissionExecutors=0without any change for Apache Spark 4.0.0 in order to help a user use this feature more easily by setting only one configuration,spark.scheduler.maxRetainedRemovedDecommissionExecutors.Why are the changes needed?
This feature was added at Apache Spark 3.4.0 via SPARK-40481 and SPARK-40979 and has been used for two years to support executor decommissioning features in the production.
Does this PR introduce any user-facing change?
No because
spark.scheduler.maxRetainedRemovedDecommissionExecutorsis still0.How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.