[SPARK-48074][Core] Improve the readability of JSON loggings #46322
+28
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @panbingkun @dtenedor as well |
common/utils/src/test/scala/org/apache/spark/util/StructuredLoggingSuite.scala
Outdated
Show resolved
Hide resolved
dongjoon-hyun
requested changes
May 1, 2024
dongjoon-hyun
approved these changes
May 1, 2024
|
Merged to master for Apache spark 4.0.0. |
|
+1, LGTM |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
### What changes were proposed in this pull request? Improve the readability of JSON loggings via: 1. Use UTC in the timestamp so that the timestamp field value is more concise. 2. Display the simple name of the logger instead of the full qualified name. 3. Display the stack trace elements with `class`/`method`/`file`/`line` instead of stringifying everything into a long string. Before changes: <img width="2129" alt="image" src="https://github.com/apache/spark/assets/1097932/a7458293-2f84-4699-bbc2-3183a078a543"> After changes: <img width="2341" alt="image" src="https://github.com/apache/spark/assets/1097932/23742bc0-4e1e-491c-83c9-b6695f41e57e"> ### Why are the changes needed? Improve the readability of Spark logs ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing UT and manually reviews ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#46322 from gengliangwang/improveLayout. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improve the readability of JSON loggings via:
class/method/file/lineinstead of stringifying everything into a long string.Before changes:
After changes:
Why are the changes needed?
Improve the readability of Spark logs
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UT and manually reviews
Was this patch authored or co-authored using generative AI tooling?
No