[SPARK-48098][INFRA] Enable NOLINT_ON_COMPILE for all except lint job
#46346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @gengliangwang . Could you review this PR when you have some time? |
gengliangwang
approved these changes
May 2, 2024
|
Thank you so much, @gengliangwang . |
|
Oh, sorry. I need to revise this PR. |
dongjoon-hyun
commented
May 2, 2024
|
Could you review this PR once more, @gengliangwang ? |
gengliangwang
approved these changes
May 2, 2024
|
Thank you for review and approval. |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
… job ### What changes were proposed in this pull request? This PR aims to enable `NOLINT_ON_COMPILE` for all except `lint` job. ### Why are the changes needed? This will reduce the redundant CPU cycle and GitHub action usage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46346 from dongjoon-hyun/SPARK-48098. Lead-authored-by: Dongjoon Hyun <dhyun@apple.com> Co-authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to enable
NOLINT_ON_COMPILEfor all exceptlintjob.Why are the changes needed?
This will reduce the redundant CPU cycle and GitHub action usage.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.