-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-48099][INFRA] Run maven-build
test only on Java 21 on MacOS14 (Apple Silicon)
#46347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 14 (Apple Silicon)`
Could you review this PR, @HyukjinKwon ? |
HyukjinKwon
approved these changes
May 3, 2024
Thank you, @HyukjinKwon ! |
Merged to master. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
May 3, 2024
### What changes were proposed in this pull request? This PR proposes to reduce the concurrency of GitHub Action Job, by removing all Maven-only builds because this is tested in daily build (https://github.com/apache/spark/actions/workflows/build_maven_java21_macos14.yml) ### Why are the changes needed? Same as #46347 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI in this PR ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46360 from HyukjinKwon/SPARK-48110. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…14 (Apple Silicon)` ### What changes were proposed in this pull request? This PR aims to reduce the concurrency of GitHub Action Job, `build_and_test.yml`, by run `maven-build` test only on `Java 21 on MacOS 14 (Apple Silicon)`. ### Why are the changes needed? - According to ASF INFRA policy, we need to reduce the job concurrency level to - https://infra.apache.org/github-actions-policy.html > All workflows MUST have a job concurrency level less than or equal to 20. - `Java 21 on MacOS 14 (Apple Silicon)` is the fastest Maven build job and covers both `Java 21` and `Apple Silicon`. <img width="632" alt="Screenshot 2024-05-02 at 14 59 14" src="https://github.com/apache/spark/assets/9700541/735819f5-6974-4fe7-ab28-3543ea67fd45"> ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Check the CI of this PR. - https://github.com/dongjoon-hyun/spark/actions/runs/8931039406/job/24532621876 <img width="283" alt="Screenshot 2024-05-02 at 15 33 12" src="https://github.com/apache/spark/assets/9700541/ea02f524-add8-4cdb-9b61-191513cb4cea"> ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46347 from dongjoon-hyun/SPARK-48099. Lead-authored-by: Dongjoon Hyun <dhyun@apple.com> Co-authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
### What changes were proposed in this pull request? This PR proposes to reduce the concurrency of GitHub Action Job, by removing all Maven-only builds because this is tested in daily build (https://github.com/apache/spark/actions/workflows/build_maven_java21_macos14.yml) ### Why are the changes needed? Same as apache#46347 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI in this PR ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46360 from HyukjinKwon/SPARK-48110. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to reduce the concurrency of GitHub Action Job,
build_and_test.yml
, by runmaven-build
test only onJava 21 on MacOS 14 (Apple Silicon)
.Why are the changes needed?
According to ASF INFRA policy, we need to reduce the job concurrency level to
Java 21 on MacOS 14 (Apple Silicon)
is the fastest Maven build job and covers bothJava 21
andApple Silicon
.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Check the CI of this PR.
Was this patch authored or co-authored using generative AI tooling?
No.