Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-48099][INFRA] Run maven-build test only on Java 21 on MacOS14 (Apple Silicon) #46347

Closed
wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented May 2, 2024

What changes were proposed in this pull request?

This PR aims to reduce the concurrency of GitHub Action Job, build_and_test.yml, by run maven-build test only on Java 21 on MacOS 14 (Apple Silicon).

Why are the changes needed?

  • According to ASF INFRA policy, we need to reduce the job concurrency level to

    All workflows MUST have a job concurrency level less than or equal to 20.

  • Java 21 on MacOS 14 (Apple Silicon) is the fastest Maven build job and covers both Java 21 and Apple Silicon.
    Screenshot 2024-05-02 at 14 59 14

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Check the CI of this PR.

Screenshot 2024-05-02 at 15 33 12

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the INFRA label May 2, 2024
@dongjoon-hyun
Copy link
Member Author

Could you review this PR, @HyukjinKwon ?

@dongjoon-hyun
Copy link
Member Author

Thank you, @HyukjinKwon !
Merged to master.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-48099 branch May 3, 2024 02:27
@dongjoon-hyun
Copy link
Member Author

Merged to master.

dongjoon-hyun pushed a commit that referenced this pull request May 3, 2024
### What changes were proposed in this pull request?

This PR proposes to reduce the concurrency of GitHub Action Job, by removing all Maven-only builds because this is tested in daily build (https://github.com/apache/spark/actions/workflows/build_maven_java21_macos14.yml)

### Why are the changes needed?

Same as #46347

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

CI in this PR

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #46360 from HyukjinKwon/SPARK-48110.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
JacobZheng0927 pushed a commit to JacobZheng0927/spark that referenced this pull request May 11, 2024
…14 (Apple Silicon)`

### What changes were proposed in this pull request?

This PR aims to reduce the concurrency of GitHub Action Job, `build_and_test.yml`, by run `maven-build` test only on `Java 21 on MacOS 14 (Apple Silicon)`.

### Why are the changes needed?

- According to ASF INFRA policy, we need to reduce the job concurrency level to
    - https://infra.apache.org/github-actions-policy.html
    > All workflows MUST have a job concurrency level less than or equal to 20.

- `Java 21 on MacOS 14 (Apple Silicon)` is the fastest Maven build job and covers both `Java 21` and `Apple Silicon`.
    <img width="632" alt="Screenshot 2024-05-02 at 14 59 14" src="https://github.com/apache/spark/assets/9700541/735819f5-6974-4fe7-ab28-3543ea67fd45">

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Check the CI of this PR.
- https://github.com/dongjoon-hyun/spark/actions/runs/8931039406/job/24532621876

<img width="283" alt="Screenshot 2024-05-02 at 15 33 12" src="https://github.com/apache/spark/assets/9700541/ea02f524-add8-4cdb-9b61-191513cb4cea">

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#46347 from dongjoon-hyun/SPARK-48099.

Lead-authored-by: Dongjoon Hyun <dhyun@apple.com>
Co-authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
JacobZheng0927 pushed a commit to JacobZheng0927/spark that referenced this pull request May 11, 2024
### What changes were proposed in this pull request?

This PR proposes to reduce the concurrency of GitHub Action Job, by removing all Maven-only builds because this is tested in daily build (https://github.com/apache/spark/actions/workflows/build_maven_java21_macos14.yml)

### Why are the changes needed?

Same as apache#46347

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

CI in this PR

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#46360 from HyukjinKwon/SPARK-48110.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants