[SPARK-48102][SS] Track duration for acquiring source/sink metrics while reporting streaming query progress #46350
+32
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reporting streaming query progress
anishshri-db
changed the title
|
cc - @HeartSaVioR - PTAL, thx ! |
|
Thanks! Merging to master. |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…ile reporting streaming query progress ### What changes were proposed in this pull request? Track duration for acquiring source/sink metrics while reporting streaming query progress ### Why are the changes needed? Change needed to help us understand how long the source/sink progress metrics calculation is taking. Also need to understand distribution if multiple sources are used Sample log: ``` 17:26:14.769 INFO org.apache.spark.sql.execution.streaming.MicroBatchExecutionContext: Extracting source progress metrics for source=MemoryStream[value#636] took duration_ms=0 17:26:14.769 INFO org.apache.spark.sql.execution.streaming.MicroBatchExecutionContext: Extracting sink progress metrics for sink=MemorySink took duration_ms=0 ``` Existing test: ``` [info] Run completed in 9 seconds, 995 milliseconds. [info] Total number of tests run: 11 [info] Suites: completed 1, aborted 0 [info] Tests: succeeded 11, failed 0, canceled 0, ignored 1, pending 0 [info] All tests passed. ``` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing unit tests ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#46350 from anishshri-db/task/SPARK-48102. Authored-by: Anish Shrigondekar <anish.shrigondekar@databricks.com> Signed-off-by: Jungtaek Lim <kabhwan.opensource@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Track duration for acquiring source/sink metrics while reporting streaming query progress
Why are the changes needed?
Change needed to help us understand how long the source/sink progress metrics calculation is taking. Also need to understand distribution if multiple sources are used
Sample log:
Existing test:
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing unit tests
Was this patch authored or co-authored using generative AI tooling?
No