[SPARK-48107][PYTHON] Exclude tests from Python distribution #46354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchammas
commented
May 3, 2024
| graft pyspark | ||
| recursive-include pyspark *.pyi py.typed *.json |
There was a problem hiding this comment.
@HyukjinKwon - Instead of this, I prefer to exclude tests as follows:
$ diff python/MANIFEST-json.in python/MANIFEST-notests.in
19c19
< recursive-include pyspark *.pyi py.typed *.json
---
> graft pyspark
31a32
> global-exclude **/tests/**That way, if we add new files in the future that don't happen to match the glob expressions on this line they will still be picked up.
But I believe you prefer the approach taken here, so I've started with that.
HyukjinKwon
approved these changes
May 3, 2024
|
Merged to master. |
|
:-) |
|
:) |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
### What changes were proposed in this pull request? Change the Python manifest so that tests are excluded from the packages that are built for distribution. ### Why are the changes needed? Tests were unintentionally included in the distributions as part of apache#44920. See [this comment](https://github.com/apache/spark/pull/44920/files#r1586979834). ### Does this PR introduce _any_ user-facing change? No, since apache#44920 hasn't been released to any users yet. ### How was this patch tested? I built Python packages and inspected `SOURCES.txt` to confirm that tests were excluded: ```sh cd python rm -rf pyspark.egg-info || echo "No existing egg info file, skipping deletion" python3 packaging/classic/setup.py sdist python3 packaging/connect/setup.py sdist find dist -name '*.tar.gz' | xargs -I _ tar xf _ --directory=dist cd .. open python/dist find python/dist -name SOURCES.txt | xargs code ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46354 from nchammas/SPARK-48107-package-json. Authored-by: Nicholas Chammas <nicholas.chammas@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change the Python manifest so that tests are excluded from the packages that are built for distribution.
Why are the changes needed?
Tests were unintentionally included in the distributions as part of #44920. See this comment.
Does this PR introduce any user-facing change?
No, since #44920 hasn't been released to any users yet.
How was this patch tested?
I built Python packages and inspected
SOURCES.txtto confirm that tests were excluded:Was this patch authored or co-authored using generative AI tooling?
No.