[SPARK-48112][CONNECT] Expose session in SparkConnectPlanner to plugins #46363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
May 3, 2024
| @@ -101,7 +101,8 @@ class SparkConnectPlanner( | |||
| throw new IllegalArgumentException("executeHolder does not belong to sessionHolder") | |||
| } | |||
|
|
|||
| private[connect] def session: SparkSession = sessionHolder.session | |||
| @DeveloperApi | |||
| def session: SparkSession = sessionHolder.session | |||
There was a problem hiding this comment.
I am fine with this for now but I really think we should probably make SparkConnectPlanner an API first
HyukjinKwon
approved these changes
May 3, 2024
...connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala
Show resolved
Hide resolved
|
Merged to master. |
|
Thank you. +1, LGTM. |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
### What changes were proposed in this pull request? This PR makes `session` in `SparkConnectPlanner` public so that it can be accessed by Spark Connect plugins. This method was public before but was made private. To prevent this from happening I have added `DeveloperApi` as an annotation. ### Why are the changes needed? To allow the development of Spark Connect plugins. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? N/A ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#46363 from tomvanbussel/SPARK-48112. Authored-by: Tom van Bussel <tom.vanbussel@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR makes
sessioninSparkConnectPlannerpublic so that it can be accessed by Spark Connect plugins. This method was public before but was made private. To prevent this from happening I have added@DeveloperApias an annotation.Why are the changes needed?
To allow the development of Spark Connect plugins.
Does this PR introduce any user-facing change?
No
How was this patch tested?
N/A
Was this patch authored or co-authored using generative AI tooling?
No