[SPARK-48114][CORE] Precompile template regex to avoid unnecessary work #46365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
May 3, 2024
There was a problem hiding this comment.
+1, LGTM. Thank you, @vladimirg-db .
Merged to master for Apache Spark 4.0.0-preview.
vladimirg-db
deleted the
vladimirg-db/precompile-regexes-in-error-classes-json-reader
branch
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
### What changes were proposed in this pull request? Error message template regex is now precompiled to avoid unnecessary work ### Why are the changes needed? `SparkRuntimeException` uses `SparkThrowableHelper`, which uses `ErrorClassesJsonReader` to create error message string from templates in `error-conditions.json`, but template regex is compiled on every `SparkRuntimeException` constructor invocation. This slows down error construction, in particular `UnivocityParser` + `FailureSafeParser`, where it's a hot path. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - `testOnly org.apache.spark.sql.errors.QueryExecutionErrorsSuite` - Manually checked csv parsing error ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#46365 from vladimirg-db/vladimirg-db/precompile-regexes-in-error-classes-json-reader. Authored-by: Vladimir Golubev <vladimir.golubev@databricks.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Error message template regex is now precompiled to avoid unnecessary work
Why are the changes needed?
SparkRuntimeExceptionusesSparkThrowableHelper, which usesErrorClassesJsonReaderto create error message string from templates inerror-conditions.json, but template regex is compiled on everySparkRuntimeExceptionconstructor invocation. This slows down error construction, in particularUnivocityParser+FailureSafeParser, where it's a hot path.Does this PR introduce any user-facing change?
No
How was this patch tested?
testOnly org.apache.spark.sql.errors.QueryExecutionErrorsSuiteWas this patch authored or co-authored using generative AI tooling?
No