[SPARK-47547][SQL] Fix inaccurate false positive rates when N is large for Bloom Filter #46370
+857
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e for Bloom Filter ### What changes were proposed in this pull request? This PR introduces a new 128 bit hashing function based on Guava's solution. Bloom filter is now created based on hashing strategy, which is decided by the bit size of the Bloom Filter. ### Why are the changes needed? When the decided bit size by Bloom Filter is greater than Integer.MAX_VALUE, 32 bit hashing function wastes the bits which index is greater than Integer.MAX_VALUE. ### Does this PR introduce _any_ user-facing change? No, hashing function is decided by BloomFilter. ### How was this patch tested? Added UT for new hashing function. Manually tested the BloomFilter with N is near 500 million. ### Was this patch authored or co-authored using generative AI tooling? No.
batubond007
changed the title
|
Hi @dongjoon-hyun , can you please review this pr which is also my first one? |
|
Gentle ping @dongjoon-hyun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR introduces a new 128 bit hashing function based on Guava's solution. Bloom filter is now created based on hashing strategy, which is decided by the bit size of the Bloom Filter.
Why are the changes needed?
When the decided bit size by Bloom Filter is greater than Integer.MAX_VALUE, 32 bit hashing function wastes the bits which index is greater than Integer.MAX_VALUE.
Does this PR introduce any user-facing change?
No, hashing function is decided by BloomFilter.
How was this patch tested?
Added UT for new hashing function. Manually tested the BloomFilter with N is near 500 million.
Was this patch authored or co-authored using generative AI tooling?
No.