[SPARK-48124][CORE] Disable structured logging for Connect-Repl by default #46387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengliangwang
approved these changes
May 5, 2024
|
@panbingkun the test failure is probably not related. Could you verify it on your local env? |
@gengliangwang |
|
Thanks, merging to master |
sinaiamonkar-sai
pushed a commit
to sinaiamonkar-sai/spark
that referenced
this pull request
May 5, 2024
…fault ### What changes were proposed in this pull request? The pr is followup apache#46383, to `disable` structured logging for` Connect-Repl` by default. ### Why are the changes needed? Before: <img width="1397" alt="image" src="https://github.com/apache/spark/assets/15246973/10d93a09-f098-4653-9e95-571481dd03e9"> After: <img width="1406" alt="image" src="https://github.com/apache/spark/assets/15246973/e3354359-d6bc-4b2c-801b-8a2c3697f78e"> ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manually test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46387 from panbingkun/SPARK-48124_FOLLOWUP. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Gengliang Wang <gengliang@apache.org>
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…fault ### What changes were proposed in this pull request? The pr is followup apache#46383, to `disable` structured logging for` Connect-Repl` by default. ### Why are the changes needed? Before: <img width="1397" alt="image" src="https://github.com/apache/spark/assets/15246973/10d93a09-f098-4653-9e95-571481dd03e9"> After: <img width="1406" alt="image" src="https://github.com/apache/spark/assets/15246973/e3354359-d6bc-4b2c-801b-8a2c3697f78e"> ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manually test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46387 from panbingkun/SPARK-48124_FOLLOWUP. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Gengliang Wang <gengliang@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr is followup #46383, to
disablestructured logging forConnect-Replby default.Why are the changes needed?
Before:
After:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually test.
Was this patch authored or co-authored using generative AI tooling?
No.