[SPARK-48141][TEST] Update the Oracle docker image version used for test and integration to use Oracle Database 23ai Free #46399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to use Oracle Database 23ai Free
yaooqinn
approved these changes
May 6, 2024
|
Also cc @gvenzl from gvenzl/oci-oracle-free#35 (comment) |
.github/workflows/build_and_test.yml
Outdated
| @@ -929,7 +929,7 @@ jobs: | |||
| HIVE_PROFILE: hive2.3 | |||
| GITHUB_PREV_SHA: ${{ github.event.before }} | |||
| SPARK_LOCAL_IP: localhost | |||
| ORACLE_DOCKER_IMAGE_NAME: gvenzl/oracle-free:23.3 | |||
| ORACLE_DOCKER_IMAGE_NAME: gvenzl/oracle-free:23.4 | |||
There was a problem hiding this comment.
Shall we remove this because we don't need this env variable, @LucaCanali and @yaooqinn ?
There was a problem hiding this comment.
sys.env.getOrElse("ORACLE_DOCKER_IMAGE_NAME", "gvenzl/oracle-free:23.4-slim") is enough, isn't it?
There was a problem hiding this comment.
BTW, if this PR affects old release branch's test coverage due to .github/workflows/build_and_test.yml change, it would be very weird. What fixed versions should we use for SPARK-48141?
dongjoon-hyun
approved these changes
May 7, 2024
There was a problem hiding this comment.
+1, LGTM. (I removed the line)
Merged to master for Apache Spark 4.0.0-preview.
Thank you, @LucaCanali and @yaooqinn .
|
Thank you @dongjoon-hyun and @yaooqinn |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…est and integration to use Oracle Database 23ai Free ### What changes were proposed in this pull request? This proposes to update the Docker image used for integration tests and builds to Oracle Database 23ai Free, version 23.4 (previously we used Oracle Database 23c Free, version 23.3) ### Why are the changes needed? This is to keep the testing infrastructure up-to-date with the latest Oracle Database Free version. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing test infrastructure. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#46399 from LucaCanali/updateOracleImage. Lead-authored-by: Luca Canali <luca.canali@cern.ch> Co-authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This proposes to update the Docker image used for integration tests and builds to Oracle Database 23ai Free, version 23.4 (previously we used Oracle Database 23c Free, version 23.3)
Why are the changes needed?
This is to keep the testing infrastructure up-to-date with the latest Oracle Database Free version.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing test infrastructure.
Was this patch authored or co-authored using generative AI tooling?
No