[SPARK-48154][PYTHON][CONNECT][TESTS] Enable PandasUDFGroupedAggParityTests.test_manual
#46418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,10 +20,11 @@ | |||
| from pyspark.testing.connectutils import ReusedConnectTestCase | |||
|
|
|||
|
|
|||
| class PandasUDFGroupedAggParityTests(GroupedAggPandasUDFTestsMixin, ReusedConnectTestCase): | |||
| @unittest.skip("Spark Connect does not support convert UNPARSED to catalyst types.") | |||
There was a problem hiding this comment.
Just a question. Which JIRA issue supports this feature?
HyukjinKwon
approved these changes
May 7, 2024
dongjoon-hyun
approved these changes
May 7, 2024
|
merged to master |
|
thanks @dongjoon-hyun and @HyukjinKwon |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…tyTests.test_manual` ### What changes were proposed in this pull request? Enable `PandasUDFGroupedAggParityTests.test_manual` ### Why are the changes needed? for test coverage ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? ci ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#46418 from zhengruifeng/enable_test_manual. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enable
PandasUDFGroupedAggParityTests.test_manualWhy are the changes needed?
for test coverage
Does this PR introduce any user-facing change?
no
How was this patch tested?
ci
Was this patch authored or co-authored using generative AI tooling?
no