[SPARK-48083][SPARK-48084][ML][TESTS] Remove JIRA comments for reenabling ML compatibility tests #46419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
May 7, 2024
HyukjinKwon
changed the title
|
Would you mind describing why those skips are legitimate in the PR description? |
dongjoon-hyun
approved these changes
May 7, 2024
dongjoon-hyun
changed the title
WeichenXu123
commented
May 7, 2024
| @@ -21,7 +21,6 @@ | |||
| from pyspark.sql import SparkSession | |||
| from pyspark.ml.tests.connect.test_legacy_mode_classification import ClassificationTestsMixin | |||
|
|
|||
| # TODO(SPARK-48083): Reenable this test case | |||
There was a problem hiding this comment.
session.copyFromLocalToFs failure with 3.5 client <> 4.0 server
this is not an issue,
copyFromLocalToFs requires spark server to config spark.connect.copyFromLocalToFs.allowDestLocal to False, because the test can only use local fs.
WeichenXu123
commented
May 7, 2024
| @@ -20,7 +20,6 @@ | |||
| from pyspark.sql import SparkSession | |||
| from pyspark.ml.tests.connect.test_legacy_mode_evaluation import EvaluationTestsMixin | |||
|
|
|||
| # TODO(SPARK-48084): Reenable this test case | |||
There was a problem hiding this comment.
This test error pyspark.ml.connect.evaluation not working in 3.5 client <> 4.0 server is caused by cloudpickle forward incompatibility, it is not related to ML code
|
Merged to branch-3.5. |
HyukjinKwon
pushed a commit
that referenced
this pull request
May 7, 2024
…ling ML compatibility tests ### What changes were proposed in this pull request? Enable spark ml test ### Why are the changes needed? For test_connect_classification.py, session.copyFromLocalToFs failure with 3.5 client <> 4.0 server this is not an issue, copyFromLocalToFs requires spark server to config spark.connect.copyFromLocalToFs.allowDestLocal to False, because the test can only use local fs. For test_connect_evaluation.py, This test error pyspark.ml.connect.evaluation not working in 3.5 client <> 4.0 server is caused by cloudpickle forward incompatibility, it is not related to ML code ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46419 from WeichenXu123/reenable-test-3.5. Authored-by: Weichen Xu <weichen.xu@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enable spark ml test
Why are the changes needed?
For test_connect_classification.py,
session.copyFromLocalToFs failure with 3.5 client <> 4.0 server
this is not an issue,
copyFromLocalToFs requires spark server to config spark.connect.copyFromLocalToFs.allowDestLocal to False, because the test can only use local fs.
For test_connect_evaluation.py,
This test error pyspark.ml.connect.evaluation not working in 3.5 client <> 4.0 server is caused by cloudpickle forward incompatibility, it is not related to ML code
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI.
Was this patch authored or co-authored using generative AI tooling?
No.