[SPARK-48163][CONNECT][TESTS] Disable SparkConnectServiceSuite.SPARK-43923: commands send events - get_resources_command
#46425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-43923: commands send events - get_resources_command`
HyukjinKwon
approved these changes
May 7, 2024
|
Thank you, @HyukjinKwon . I believe this will give a proper and better visibility to this test case issue before |
yaooqinn
approved these changes
May 7, 2024
|
Thank you, @yaooqinn . |
|
Merged to master for Apache Spark 4.0.0-preview. |
dongjoon-hyun
added a commit
that referenced
this pull request
May 7, 2024
### What changes were proposed in this pull request? This PR aims to merge connect back to the original test pipeline to reduce the maximum concurrency of GitHub Action by one. - https://infra.apache.org/github-actions-policy.html > All workflows SHOULD have a job concurrency level less than or equal to 15. ### Why are the changes needed? This is a partial recover from the following. - #45107 We stabilized the root cause of #45107 via the following PRs. In addition we will disable a flaky test case if exists. - #46395 - #46396 - #46425 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46441 from dongjoon-hyun/SPARK-48174. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
|
It looks like the failure just downshifted to the next one |
|
😢 |
|
Let me just revert it out for now ..... |
|
Thank you for reporting and reverting, @yaooqinn and @HyukjinKwon . Ya, I agree. It's not a single command event issue. It seems that the whole |
|
I'll re-try later~ |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…-43923: commands send events - get_resources_command` ### What changes were proposed in this pull request? This PR aims to disable a flaky test, `SparkConnectServiceSuite.SPARK-43923: commands send events - get_resources_command`, temporarily. To re-enable this, SPARK-48164 is created as a blocker issue for 4.0.0. ### Why are the changes needed? This test case was added at `Apache Spark 3.5.0`, but it has been flaky and causes many re-tries in our GitHub Action CI environment. - apache#42454 - https://github.com/apache/spark/actions/runs/8979348499/job/24661200052 ``` [info] - SPARK-43923: commands send events ((get_resources_command { [info] } [info] ,None)) *** FAILED *** (35 milliseconds) [info] VerifyEvents.this.listener.executeHolder.isDefined was false (SparkConnectServiceSuite.scala:873) ``` This PR aims to stabilize CI first and to focus this flaky issue as a blocker level before going on `Spark Connect GA` in SPARK-48164 before Apache Spark 4.0.0. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46425 from dongjoon-hyun/SPARK-48163. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
### What changes were proposed in this pull request? This PR aims to merge connect back to the original test pipeline to reduce the maximum concurrency of GitHub Action by one. - https://infra.apache.org/github-actions-policy.html > All workflows SHOULD have a job concurrency level less than or equal to 15. ### Why are the changes needed? This is a partial recover from the following. - apache#45107 We stabilized the root cause of apache#45107 via the following PRs. In addition we will disable a flaky test case if exists. - apache#46395 - apache#46396 - apache#46425 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46441 from dongjoon-hyun/SPARK-48174. Authored-by: Dongjoon Hyun <dhyun@apple.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to disable a flaky test,
SparkConnectServiceSuite.SPARK-43923: commands send events - get_resources_command, temporarily.To re-enable this, SPARK-48164 is created as a blocker issue for 4.0.0.
Why are the changes needed?
This test case was added at
Apache Spark 3.5.0, but it has been flaky and causes many re-tries in our GitHub Action CI environment.[SPARK-44776][CONNECT] Add ProducedRowCount to SparkListenerConnectOperationFinished #42454
https://github.com/apache/spark/actions/runs/8979348499/job/24661200052
This PR aims to stabilize CI first and to focus this flaky issue as a blocker level before going on
Spark Connect GAin SPARK-48164 before Apache Spark 4.0.0.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.