[SPARK-48166][SQL] Avoid using BadRecordException as user-facing error in VariantExpressionEvalUtils #46428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirg-db
changed the title
cloud-fan
approved these changes
May 7, 2024
|
thanks, merging to master! |
vladimirg-db
deleted the
vladimirg-db/get-rid-of-bad-record-exception-in-variant-expression-eval-utils
branch
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…r in VariantExpressionEvalUtils ### What changes were proposed in this pull request? Stop using `BadRecordException` in a user-facing context. Currently it is thrown then the `parse_json` input is malformed. ### Why are the changes needed? `BadRecordException` is an internal exception designed for `FailureSafeParser`. ### Does this PR introduce _any_ user-facing change? Yes, `parse_json` will not expose `BadRecordException` in error. ### How was this patch tested? `testOnly org.apache.spark.sql.catalyst.expressions.variant.VariantExpressionEvalUtilsSuite` ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#46428 from vladimirg-db/vladimirg-db/get-rid-of-bad-record-exception-in-variant-expression-eval-utils. Authored-by: Vladimir Golubev <vladimir.golubev@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Stop using
BadRecordExceptionin a user-facing context. Currently it is thrown then theparse_jsoninput is malformed.Why are the changes needed?
BadRecordExceptionis an internal exception designed forFailureSafeParser.Does this PR introduce any user-facing change?
Yes,
parse_jsonwill not exposeBadRecordExceptionin error.How was this patch tested?
testOnly org.apache.spark.sql.catalyst.expressions.variant.VariantExpressionEvalUtilsSuiteWas this patch authored or co-authored using generative AI tooling?
No