Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-48179][INFRA][3.5] Pin nbsphinx to 0.9.3 #46448

Closed
wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented May 7, 2024

What changes were proposed in this pull request?

This PR aims to pin nbsphinx to 0.9.3 to recover branch-3.5 CI.

Why are the changes needed?

From yesterday, branch-3.5 commit build is broken.

Exception occurred:
  File "/usr/local/lib/python3.9/dist-packages/nbsphinx/__init__.py", line 1316, in apply
    for section in self.document.findall(docutils.nodes.section):
AttributeError: 'document' object has no attribute 'findall'
The full traceback has been saved in /tmp/sphinx-err-qz4y0bav.log, if you want to report the issue to the developers.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs on this PR.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the INFRA label May 7, 2024
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-XXX][INFRA][3.5] Pin nbsphinx to `0.9.3' [SPARK-XXX][INFRA][3.5] Pin nbsphinx to 0.9.3 May 7, 2024
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-XXX][INFRA][3.5] Pin nbsphinx to 0.9.3 [SPARK-48179][INFRA][3.5] Pin nbsphinx to 0.9.3 May 7, 2024
@dongjoon-hyun dongjoon-hyun marked this pull request as ready for review May 7, 2024 21:44
@dongjoon-hyun
Copy link
Member Author

Linter passed.

Screenshot 2024-05-07 at 15 16 41

@dongjoon-hyun
Copy link
Member Author

Could you review this PR to recover branch-3.5, @huaxingao ?

Copy link
Contributor

@huaxingao huaxingao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @dongjoon-hyun

@dongjoon-hyun
Copy link
Member Author

Thank you!
Merged to branch-3.5.

dongjoon-hyun added a commit that referenced this pull request May 7, 2024
### What changes were proposed in this pull request?

This PR aims to pin `nbsphinx` to `0.9.3` to recover `branch-3.5` CI.

### Why are the changes needed?

From yesterday, `branch-3.5` commit build is broken.
- https://github.com/apache/spark/actions/runs/8978558438/job/24659197282
```
Exception occurred:
  File "/usr/local/lib/python3.9/dist-packages/nbsphinx/__init__.py", line 1316, in apply
    for section in self.document.findall(docutils.nodes.section):
AttributeError: 'document' object has no attribute 'findall'
The full traceback has been saved in /tmp/sphinx-err-qz4y0bav.log, if you want to report the issue to the developers.
```

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs on this PR.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #46448 from dongjoon-hyun/nbsphinx.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
@dongjoon-hyun dongjoon-hyun deleted the nbsphinx branch May 8, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants