[SPARK-48126][Core] Make spark.log.structuredLogging.enabled effective
#46452
+31
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @panbingkun |
You are right. I just updated the description. |
dongjoon-hyun
approved these changes
May 8, 2024
HyukjinKwon
approved these changes
May 8, 2024
|
@dongjoon-hyun @HyukjinKwon Thanks for the review. I am merging this one to master |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
### What changes were proposed in this pull request? Currently, the spark conf `spark.log.structuredLogging.enabled` is not taking effect. The current code base checks this config in the method `prepareSubmitEnvironment`. However, Log4j is already initialized before that. This PR is to fix it by checking the config `spark.log.structuredLogging.enabled` before the initialization of Log4j. Also, this PR enhances the doc for this configuration. ### Why are the changes needed? Bug fix. After the fix, the Spark conf `spark.log.structuredLogging.enabled` takes effect. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manual test. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: GPT-4 I used GPT-4 to improve the documents. Closes apache#46452 from gengliangwang/makeConfEffective. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Gengliang Wang <gengliang@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, the spark conf
spark.log.structuredLogging.enabledis not taking effect. The current code base checks this config in the methodprepareSubmitEnvironment. However, Log4j is already initialized before that.This PR is to fix it by checking the config
spark.log.structuredLogging.enabledbefore the initialization of Log4j.Also, this PR enhances the doc for this configuration.
Why are the changes needed?
Bug fix. After the fix, the Spark conf
spark.log.structuredLogging.enabledtakes effect.Does this PR introduce any user-facing change?
No
How was this patch tested?
Manual test.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: GPT-4
I used GPT-4 to improve the documents.