Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-48183][PYTHON][DOCS] Update error contribution guide to respect new error class file #46455

Closed
wants to merge 1 commit into from

Conversation

itholic
Copy link
Contributor

@itholic itholic commented May 8, 2024

What changes were proposed in this pull request?

This PR proposes to update error contribution guide to respect new error class file.

Why are the changes needed?

SPARK-46894 recently moved the error class definition from error_classes.py to error-conditions.json, but some of documentation still describes the old file.

Does this PR introduce any user-facing change?

No API changes, but the user-facing documentation will be updated.

How was this patch tested?

Passed dev/lint-python, and also the existing CI should pass.

Was this patch authored or co-authored using generative AI tooling?

No.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@dongjoon-hyun
Copy link
Member

Merged to master.

JacobZheng0927 pushed a commit to JacobZheng0927/spark that referenced this pull request May 11, 2024
…t new error class file

### What changes were proposed in this pull request?

This PR proposes to update error contribution guide to respect new error class file.

### Why are the changes needed?

SPARK-46894 recently moved the error class definition from `error_classes.py` to `error-conditions.json`, but some of documentation still describes the old file.

### Does this PR introduce _any_ user-facing change?

No API changes, but the user-facing documentation will be updated.

### How was this patch tested?

Passed `dev/lint-python`, and also the existing CI should pass.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#46455 from itholic/SPARK-48183.

Authored-by: Haejoon Lee <haejoon.lee@databricks.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants