[SPARK-48185][SQL] Fix 'symbolic reference class is not accessible: class sun.util.calendar.ZoneInfo' #46457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lass sun.util.calendar.ZoneInfo'
dongjoon-hyun
approved these changes
May 8, 2024
LuciferYang
reviewed
May 8, 2024
| @@ -197,8 +197,8 @@ trait SparkDateTimeUtils { | |||
| rebaseJulianToGregorianDays(julianDays) | |||
| } | |||
|
|
|||
| private val zoneInfoClassName = "sun.util.calendar.ZoneInfo" | |||
| private val getOffsetsByWallHandle = { | |||
| private lazy val zoneInfoClassName = "sun.util.calendar.ZoneInfo" | |||
There was a problem hiding this comment.
Is it necessary to use lazy for this since zoneInfoClassName is just a String? 'Lazy' comes with the cost of locking.
There was a problem hiding this comment.
On the other hand, if TimeZone.getDefault.getOffset(localMillis) can be uniformly used to get timeZoneOffset in the toJavaDate function, then the use of the MethodHandle mechanism can be avoided here.
There was a problem hiding this comment.
On the other hand, if TimeZone.getDefault.getOffset(localMillis) can be uniformly used to get timeZoneOffset in the toJavaDate function, then the use of the MethodHandle mechanism can be avoided here.
It seems that ZoneInfo.getOffset doesn't support daylight saving transitions?
There was a problem hiding this comment.
Not sure, but:
- Using
TimeZone.getDefault.getOffset(localMillis), all tests can pass, perhaps the unit test coverage is not comprehensive, but what would be the counterexample? - Looking at the inverse function
fromJavaDateoftoJavaDate, it does not take into account the scenario ofZoneInfo
yaooqinn
commented
May 8, 2024
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkDateTimeUtils.scala
Outdated
Show resolved
Hide resolved
…kDateTimeUtils.scala
LuciferYang
approved these changes
May 8, 2024
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…lass sun.util.calendar.ZoneInfo' ### What changes were proposed in this pull request? I met the error below while debugging UTs because of loading `sun.util.calendar.ZoneInfo` eagerly. This PR makes the relevant variables lazy. ```log Caused by: java.lang.IllegalAccessException: symbolic reference class is not accessible: class sun.util.calendar.ZoneInfo, from interface org.apache.spark.sql.catalyst.util.SparkDateTimeUtils (unnamed module 65d6b83b) at java.base/java.lang.invoke.MemberName.makeAccessException(MemberName.java:955) at java.base/java.lang.invoke.MethodHandles$Lookup.checkSymbolicClass(MethodHandles.java:3686) at java.base/java.lang.invoke.MethodHandles$Lookup.resolveOrFail(MethodHandles.java:3646) at java.base/java.lang.invoke.MethodHandles$Lookup.findVirtual(MethodHandles.java:2680) at org.apache.spark.sql.catalyst.util.SparkDateTimeUtils.$init$(SparkDateTimeUtils.scala:206) at org.apache.spark.sql.catalyst.util.DateTimeUtils$.<clinit>(DateTimeUtils.scala:41) ... 82 more ``` ### Why are the changes needed? sun.util.calendar.ZoneInfo is inaccessible in some scenarios. ### Does this PR introduce _any_ user-facing change? Yes, such errors might be delayed from backend-scheduling to job-scheduling ### How was this patch tested? I tested with idea and UT debugging locally ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#46457 from yaooqinn/SPARK-48185. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Kent Yao <yao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I met the error below while debugging UTs because of loading
sun.util.calendar.ZoneInfoeagerly. This PR makes the relevant variables lazy.Why are the changes needed?
sun.util.calendar.ZoneInfo is inaccessible in some scenarios.
Does this PR introduce any user-facing change?
Yes, such errors might be delayed from backend-scheduling to job-scheduling
How was this patch tested?
I tested with idea and UT debugging locally
Was this patch authored or co-authored using generative AI tooling?
no