-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-48192][INFRA] Enable TPC-DS tests in forked repository #46470
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need this, thanks!
Merged to master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Thanks!
Let me backport this to branch-3.5 to apply the same benefits. Thanks! |
This PR is a sort of a followup of #46361. It proposes to run TPC-DS and Docker integration tests in PRs (that does not consume ASF resources). TPC-DS and Docker integration stuff at least have to be tested in the PR if the PR touches the codes related to that. No, test-only. Manually No. Closes #46470 from HyukjinKwon/SPARK-48192. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit f693abc) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
This is backported to |
This PR is a sort of a followup of #46361. It proposes to run TPC-DS and Docker integration tests in PRs (that does not consume ASF resources). TPC-DS and Docker integration stuff at least have to be tested in the PR if the PR touches the codes related to that. No, test-only. Manually No. Closes #46470 from HyukjinKwon/SPARK-48192. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit f693abc) Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit 8277921) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
### What changes were proposed in this pull request? This PR is a sort of a followup of apache#46361. It proposes to run TPC-DS and Docker integration tests in PRs (that does not consume ASF resources). ### Why are the changes needed? TPC-DS and Docker integration stuff at least have to be tested in the PR if the PR touches the codes related to that. ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Manually ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46470 from HyukjinKwon/SPARK-48192. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
What changes were proposed in this pull request?
This PR is a sort of a followup of #46361. It proposes to run TPC-DS and Docker integration tests in PRs (that does not consume ASF resources).
Why are the changes needed?
TPC-DS and Docker integration stuff at least have to be tested in the PR if the PR touches the codes related to that.
Does this PR introduce any user-facing change?
No, test-only.
How was this patch tested?
Manually
Was this patch authored or co-authored using generative AI tooling?
No.