Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-48192][INFRA] Enable TPC-DS tests in forked repository #46470

Closed
wants to merge 1 commit into from

Conversation

HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR is a sort of a followup of #46361. It proposes to run TPC-DS and Docker integration tests in PRs (that does not consume ASF resources).

Why are the changes needed?

TPC-DS and Docker integration stuff at least have to be tested in the PR if the PR touches the codes related to that.

Does this PR introduce any user-facing change?

No, test-only.

How was this patch tested?

Manually

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the INFRA label May 8, 2024
Copy link
Contributor

@uros-db uros-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need this, thanks!

@HyukjinKwon
Copy link
Member Author

Merged to master.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thanks!

@dongjoon-hyun
Copy link
Member

Let me backport this to branch-3.5 to apply the same benefits. Thanks!

dongjoon-hyun pushed a commit that referenced this pull request May 8, 2024
This PR is a sort of a followup of #46361. It proposes to run TPC-DS and Docker integration tests in PRs (that does not consume ASF resources).

TPC-DS and Docker integration stuff at least have to be tested in the PR if the PR touches the codes related to that.

No, test-only.

Manually

No.

Closes #46470 from HyukjinKwon/SPARK-48192.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit f693abc)
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
@dongjoon-hyun
Copy link
Member

This is backported to branch-3.5 via 8277921

dongjoon-hyun pushed a commit that referenced this pull request May 8, 2024
This PR is a sort of a followup of #46361. It proposes to run TPC-DS and Docker integration tests in PRs (that does not consume ASF resources).

TPC-DS and Docker integration stuff at least have to be tested in the PR if the PR touches the codes related to that.

No, test-only.

Manually

No.

Closes #46470 from HyukjinKwon/SPARK-48192.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit f693abc)
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit 8277921)
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
JacobZheng0927 pushed a commit to JacobZheng0927/spark that referenced this pull request May 11, 2024
### What changes were proposed in this pull request?

This PR is a sort of a followup of apache#46361. It proposes to run TPC-DS and Docker integration tests in PRs (that does not consume ASF resources).

### Why are the changes needed?

TPC-DS and Docker integration stuff at least have to be tested in the PR if the PR touches the codes related to that.

### Does this PR introduce _any_ user-facing change?

No, test-only.

### How was this patch tested?

Manually

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#46470 from HyukjinKwon/SPARK-48192.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants