[SPARK-47803][FOLLOWUP] Check nulls when casting nested type to variant. #46486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cloud-fan could you help review? Thanks a lot! |
cloud-fan
approved these changes
May 9, 2024
|
The docker test failure is unrelated, thanks, merging to master! |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
### What changes were proposed in this pull request? It adds null checks when accessing a nested element when casting a nested type to variant. It is necessary because the `get` API doesn't guarantee to return null when the slot is null. For example, `ColumnarArray.get` may return the default value of a primitive type if the slot is null. ### Why are the changes needed? It is a bug fix is necessary for the cast-to-variant expression to work correctly. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Two new unit tests. One directly uses `ColumnarArray` as the input of the cast. The other creates a real-world situation where `ColumnarArray` is the input of the cast (scan). Both of them would fail without the code change in this PR. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46486 from chenhao-db/fix_cast_nested_to_variant. Authored-by: Chenhao Li <chenhao.li@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It adds null checks when accessing a nested element when casting a nested type to variant. It is necessary because the
getAPI doesn't guarantee to return null when the slot is null. For example,ColumnarArray.getmay return the default value of a primitive type if the slot is null.Why are the changes needed?
It is a bug fix is necessary for the cast-to-variant expression to work correctly.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Two new unit tests. One directly uses
ColumnarArrayas the input of the cast. The other creates a real-world situation whereColumnarArrayis the input of the cast (scan). Both of them would fail without the code change in this PR.Was this patch authored or co-authored using generative AI tooling?
No.