Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-48225][BUILD] Upgrade sbt to 1.10.0 #46517

Closed
wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented May 9, 2024

What changes were proposed in this pull request?

This PR aims to try sbt to 1.10.0.

Why are the changes needed?

So far, we couldn't upgrade SBT like the following.

Previously, we couldn't upgrade SBT due to its issues like the dependency resolution. SBT 1.10.0 is updated with Coursier 2.1.9 .

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the BUILD label May 9, 2024
@dongjoon-hyun
Copy link
Member Author

This is a new test to check if the bug is fixed or not.

cc @panbingkun and @LuciferYang .

@dongjoon-hyun
Copy link
Member Author

Unfortunately, it turns out that the bug still exists.

[error] lmcoursier.internal.shaded.coursier.error.FetchError$DownloadingArtifacts: Error fetching artifacts:
[error] file:/root/.m2/repository/org/scala-lang/scala-library/2.13.10/scala-library-2.13.10.jar: not found: /root/.m2/repository/org/scala-lang/scala-library/2.13.10/scala-library-2.13.10.jar
[error] 

@dongjoon-hyun
Copy link
Member Author

Let me open this PR for a while before closing.

@LuciferYang
Copy link
Contributor

@dongjoon-hyun I was discussing this issue with @panbingkun offline yesterday. From the responses of sbt and coursier, it seems difficult to solve this problem in the short term without some handling of Resolver.mavenLocal. I suggest that @panbingkun conduct some performance tests to determine whether this issue can be bypassed by disabling Resolver.mavenLocal:

@dongjoon-hyun
Copy link
Member Author

Thank you so much for sharing!

@dongjoon-hyun dongjoon-hyun deleted the SPARK-48225 branch May 10, 2024 03:26
@panbingkun
Copy link
Contributor

@dongjoon-hyun I was discussing this issue with @panbingkun offline yesterday. From the responses of sbt and coursier, it seems difficult to solve this problem in the short term without some handling of Resolver.mavenLocal. I suggest that @panbingkun conduct some performance tests to determine whether this issue can be bypassed by disabling Resolver.mavenLocal:

Yeah, let me do some performance tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants