[SPARK-48295][PS] Turn on compute.ops_on_diff_frames by default
#46602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will add it to release note soon |
itholic
reviewed
May 16, 2024
Comment on lines
+494
to
+495
| >>> with ps.option_context("compute.ops_on_diff_frames", False): | ||
| ... ps.DataFrame(data=sdf, index=pd.Index([0, 1, 2])) |
There was a problem hiding this comment.
I think maybe now we can just remove the negative cases from the doctests and keep only UTs??
There was a problem hiding this comment.
I am not sure, @HyukjinKwon wdyt?
Comment on lines
+513
to
+514
| >>> with ps.option_context("compute.ops_on_diff_frames", False): | ||
| ... ps.DataFrame(data=sdf, index=ps.Index([0, 1, 2])) |
HyukjinKwon
approved these changes
May 16, 2024
zhengruifeng
force-pushed
the
turn_on_ops_on_diff_frames
branch
from
2458d35
to
1367024
Compare
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Turn on
compute.ops_on_diff_framesby defaultWhy are the changes needed?
1, in most cases, this config need to be turned on to enable computation with different dataframes;
2, enable
compute.ops_on_diff_framesshould not break any workloads, it should only enable more;Does this PR introduce any user-facing change?
yes, this config is turned on by default
How was this patch tested?
updated tests
Was this patch authored or co-authored using generative AI tooling?
no