[SPARK-48384][BUILD] Exclude io.netty:netty-tcnative-boringssl-static from zookeeper
#46695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c` from `zookeeper`
|
Although I read inside the contents of |
If that's the case, both fine for me |
|
cc @mridulm and @hasnain-db as the change is related to SSL dependency |
|
Using 2.0.65 seems fine to me (and preferred) |
dongjoon-hyun
approved these changes
May 22, 2024
LuciferYang
approved these changes
May 23, 2024
|
Merged into master for Spark 4.0. Thanks @panbingkun @dongjoon-hyun @hasnain-db and @pan3793 ~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to exclude
io.netty:netty-tcnative-boringssl-staticfromzookeeper.Why are the changes needed?
1.According to:
https://github.com/netty/netty-tcnative/blob/c9b4b6ab62cdbfb4aab6ab3efb8dd7cf73f353ad/boringssl-static/pom.xml#L970-L982
the
io.netty:netty-tcnative-boringssl-staticis composed of:io.netty:netty-tcnative-boringssl-static:linux-aarch_64io.netty:netty-tcnative-boringssl-static:linux-x86_64io.netty:netty-tcnative-boringssl-static:osx-aarch_64io.netty:netty-tcnative-boringssl-static:osx-x86_64io.netty:netty-tcnative-boringssl-staticwindows-x86_64and our
common/network-common/pom.xmlfile already explicitly depends on them.2.Their versions are different in
dev/deps/spark-deps-hadoop-3-hive-2.3Let's keep one version to avoid conflicts.
3.In the
pom.xmlfile, zookeeper already has othernettyrelated exclusions, eg:https://github.com/apache/spark/blob/master/pom.xml#L1838-L1842
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.