[SPARK-48650][PYTHON] Display correct call site from IPython Notebook #47009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@allisonwang-db Actually that is a good point. Let me try highlighting and providing more useful debugging information from error message. |
|
Now we use the cell number instead of file name for better debuggability. Updated before/after in PR description. cc @allisonwang-db FYI |
HyukjinKwon
reviewed
Jun 19, 2024
HyukjinKwon
approved these changes
Jun 19, 2024
…ontext_on_notebook
allisonwang-db
approved these changes
Jun 19, 2024
ueshin
approved these changes
Jun 20, 2024
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to display correct call site information from IPython Notebook.
Why are the changes needed?
We added
DataFrameQueryContextfor PySpark error message from #45377, but it does not working very well from IPython Notebook.Does this PR introduce any user-facing change?
No API changes, but the user-facing error message from IPython Notebook will be improved:
Before
After
NOTE: This also works when command is executed across multiple cells:
How was this patch tested?
Manually tested with IPython Notebook.
Was this patch authored or co-authored using generative AI tooling?
No