-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-48639][CONNECT][PYTHON] Add Origin to Relation.RelationCommon #47024
Conversation
// (Required) Shared relation metadata. | ||
string source_info = 1; | ||
// (Optional) Shared relation metadata. | ||
string source_info = 1 [deprecated=true]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems source_info
is unused yet in the codebase ... ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we add this field at the first place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we wanted to leverage it somewhere codepoint but I think we ended up with not using it. @grundprinzip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to do what origin does, I had all prototypes etc ready, but never time. You can simply remove this field and mark the id reserved.
string source_info = 1 [deprecated=true]; | |
reserved 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually complains that it's a breaking change:
Run bufbuild/buf-breaking-action@v1
Error: Previously present field "1" with name "source_info" on message "RelationCommon" was deleted.
Error: buf found 1 breaking changes.
I can port this change to branch-3.5 if that's fine.
…ions.proto Co-authored-by: Martin Grund <grundprinzip@gmail.com>
Merged to master and branch-3.5 partially |
This PR proposes to add `Origin` (from #46789) to `Relation.RelationCommon` To have the common protobuf message to keep the source code info. No. This is not used. CI should validate protobuf definition, and exiting tests should pass. No. Closes #47024 from HyukjinKwon/SPARK-48639. Lead-authored-by: Hyukjin Kwon <gurwls223@apache.org> Co-authored-by: Hyukjin Kwon <gurwls223@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 09cb592) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
What changes were proposed in this pull request?
This PR proposes to add
Origin
(from #46789) toRelation.RelationCommon
Why are the changes needed?
To have the common protobuf message to keep the source code info.
Does this PR introduce any user-facing change?
No. This is not used.
How was this patch tested?
CI should validate protobuf definition, and exiting tests should pass.
Was this patch authored or co-authored using generative AI tooling?
No.