-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MINOR][TESTS] Replace getResource
with getWorkspaceFilePath
to enable HiveUDFSuite
to run successfully in the IDE
#47194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nable `HiveUDFSuite` to run successfully in the IDE
Error detail:
|
HyukjinKwon
approved these changes
Jul 3, 2024
LuciferYang
approved these changes
Jul 3, 2024
yaooqinn
approved these changes
Jul 3, 2024
Merged to master. |
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Jul 10, 2024
…nable `HiveUDFSuite` to run successfully in the IDE ### What changes were proposed in this pull request? The pr aims to replace `getResource` with `getWorkspaceFilePath` to enable `HiveUDFSuite#hive struct udf` to run successfully in the IDE. ### Why are the changes needed? - Before: <img width="1269" alt="image" src="https://github.com/apache/spark/assets/15246973/be0c770b-3381-4ca9-9485-728bf4d23943"> - After: <img width="871" alt="image" src="https://github.com/apache/spark/assets/15246973/ac1b0dad-9ed0-441f-ad69-bca826207a55"> ### Does this PR introduce _any_ user-facing change? No, only test. ### How was this patch tested? - Pass GA - Manually test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47194 from panbingkun/minor_HiveUDFSuite. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to replace
getResource
withgetWorkspaceFilePath
to enableHiveUDFSuite#hive struct udf
to run successfully in the IDE.Why are the changes needed?
Before:
After:
Does this PR introduce any user-facing change?
No, only test.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.