Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-47911][SQL][FOLLOWUP] Rename UTF8 to UTF-8 in spark.sql.binaryOutputStyle #47322

Closed
wants to merge 2 commits into from

Conversation

yaooqinn
Copy link
Member

What changes were proposed in this pull request?

Make a follow-up for SPARK-47911 to rename UTF8 to UTF-8 of spark.sql.binaryOutputStyle, so that we could have a consistent name with org.apache.spark.sql.catalyst.util.CharsetProvider.VALID_CHARSETS and java.nio.charset.StandardCharsets.UTF_8

Why are the changes needed?

reduce cognitive cost for users

Does this PR introduce any user-facing change?

no, unreleased feature

How was this patch tested?

existing tests

Was this patch authored or co-authored using generative AI tooling?

no

@github-actions github-actions bot added the SQL label Jul 12, 2024
@yaooqinn
Copy link
Member Author

cc @cloud-fan @dongjoon-hyun thanks

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @yaooqinn !

@dongjoon-hyun
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants