Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARK-6063 #4815

Closed
wants to merge 3 commits into from
Closed

SPARK-6063 #4815

wants to merge 3 commits into from

Conversation

msjgriffiths
Copy link
Contributor

Remove unicode characters from MLlib file.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@pwendell
Copy link
Contributor

LGTM

1 similar comment
@jkbradley
Copy link
Member

LGTM

@SparkQA
Copy link

SparkQA commented Feb 27, 2015

Test build #623 has started for PR 4815 at commit bcd7de1.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 27, 2015

Test build #623 has finished for PR 4815 at commit bcd7de1.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • logError("User class threw exception: " + cause.getMessage, cause)

@mengxr
Copy link
Contributor

mengxr commented Feb 27, 2015

test this please

@SparkQA
Copy link

SparkQA commented Feb 27, 2015

Test build #28091 has started for PR 4815 at commit bcd7de1.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 27, 2015

Test build #28091 has finished for PR 4815 at commit bcd7de1.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • logError("User class threw exception: " + cause.getMessage, cause)

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28091/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Feb 27, 2015

Test build #624 has started for PR 4815 at commit bcd7de1.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 28, 2015

Test build #624 has finished for PR 4815 at commit bcd7de1.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • logError("User class threw exception: " + cause.getMessage, cause)

@jkbradley
Copy link
Member

Not sure why these unrelated tests are failing.... By the way, can you please add more of a title to the PR?

@srowen
Copy link
Member

srowen commented Feb 28, 2015

I don't think it's necessary to wait on Jenkins. This doc change can't cause a problem. We can fix the title on merge too. I'll wait anyway for that, but figure one of us can just merge soon in any event.

@asfgit asfgit closed this in b36b1bc Feb 28, 2015
asfgit pushed a commit that referenced this pull request Mar 25, 2015
…n LDAModel.scala

Remove unicode characters from MLlib file.

Author: Michael Griffiths <msjgriffiths@gmail.com>
Author: Griffiths, Michael (NYC-RPM) <michael.griffiths@reprisemedia.com>

Closes #4815 from msjgriffiths/SPARK-6063 and squashes the following commits:

bcd7de1 [Griffiths, Michael (NYC-RPM)] Change \u201D quote marks around 'theta' to standard single apostrophe (\x27)
38eb535 [Michael Griffiths] Merge pull request #2 from apache/master
b08e865 [Michael Griffiths] Merge pull request #1 from apache/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants