[SPARK-6081] Support fetching http/https uris in driver runner. #4832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #28123 has finished for PR 4832 at commit
|
|
Test failure doesn't look anything to do with my change? |
|
Unrelated it seems. This would require a JIRA. I'm not sure about how important this is vs passing the SecurityManager around one more layer, but in any event the change is not big. I defer to others for an opinion. |
tnachen
changed the title
|
I'm curious too about SecurityManager, let me know what makes sense about it. |
|
retest this please |
| @@ -468,6 +468,7 @@ private[spark] object Utils extends Logging { | |||
| in: InputStream, | |||
| destFile: File, | |||
| fileOverwrite: Boolean): Unit = { | |||
| logDebug(s"Creating temp file in ${destFile.getParentFile.getAbsolutePath}") | |||
There was a problem hiding this comment.
I don't think we should add this
|
Looks good. |
|
Test build #29126 has finished for PR 4832 at commit
|
|
I'm merging this into master after fixing the comments myself. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if passed uris such as http/https, it won't able to fetch them as it only calls HadoopFs get.
This fix utilizes the existing util method to fetch remote uris as well.