Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored Dataframe join comment to use correct parameter ordering #4847

Closed
wants to merge 2 commits into from
Closed

Refactored Dataframe join comment to use correct parameter ordering #4847

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e353340
Updated comments use correct sample code for Dataframe joins
Mar 2, 2015
ebc1efa
Merge pull request #1 from peerside/peerside-patch-1
Mar 2, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala
View file
Open in desktop
Expand Up @@ -337,11 +337,11 @@ class DataFrame protected[sql](
* {{{
* // Scala:
* import org.apache.spark.sql.functions._
* df1.join(df2, "outer", $"df1Key" === $"df2Key")
* df1.join(df2, $"df1Key" === $"df2Key", "outer")
*
* // Java:
* import static org.apache.spark.sql.functions.*;
* df1.join(df2, "outer", col("df1Key") === col("df2Key"));
* df1.join(df2, col("df1Key") === col("df2Key"), "outer");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually while you are at it, do you mind fixing the java example? it definitely wouldn't work with col("df1key") === col("df2key").

I think you need col("df1Key").equalTo(col("df2Key"))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make this change while merging.

* }}}
*
* @param right Right side of the join.
Expand Down