[SPARK-6120] [mllib] Warnings about memory in tree, ensemble model save #4864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with too small a Java heap size
|
Test build #28211 has started for PR 4864 at commit
|
| // SPARK-6120: We do a hacky check here so users understand why save() is failing | ||
| // when they run the ML guide example. | ||
| // TODO: Fix this issue for real. | ||
| val driverMemory = sc.getConf.getOption("spark.driver.memory") |
There was a problem hiding this comment.
Move this into the the if (sc.isLocal) branch.
|
Test build #28213 has started for PR 4864 at commit
|
|
Test build #28213 has finished for PR 4864 at commit
|
|
Test FAILed. |
|
Test build #28211 has finished for PR 4864 at commit
|
|
Test PASSed. |
asfgit
pushed a commit
that referenced
this pull request
Mar 3, 2015
Issue: When the Python DecisionTree example in the programming guide is run, it runs out of Java Heap Space when using the default memory settings for the spark shell. This prints a warning. CC: mengxr Author: Joseph K. Bradley <joseph@databricks.com> Closes #4864 from jkbradley/dt-save-heap and squashes the following commits: 02e8daf [Joseph K. Bradley] fixed based on code review 7ecb1ed [Joseph K. Bradley] Added warnings about memory when calling tree and ensemble model save with too small a Java heap size (cherry picked from commit c2fe3a6) Signed-off-by: Xiangrui Meng <meng@databricks.com>
|
LGTM. Merged into master and branch-1.3. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When the Python DecisionTree example in the programming guide is run, it runs out of Java Heap Space when using the default memory settings for the spark shell.
This prints a warning.
CC: @mengxr