Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-6178][Shuffle] Removed unused imports #4900

Closed
wants to merge 3 commits into from
Closed

[SPARK-6178][Shuffle] Removed unused imports #4900

wants to merge 3 commits into from

Conversation

vinodkc
Copy link
Contributor

@vinodkc vinodkc commented Mar 5, 2015

Author: Vinod K C vinod.kc@huawei.com

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

adrian-wang
adrian-wang reviewed Mar 5, 2015
View reviewed changes
network/common/src/main/java/org/apache/spark/network/TransportContext.java
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import java.util.List;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the dependencies should be ordered as

  1. java lib
  2. scala lib
  3. 3-rd party lib
  4. spark packages

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the order as per comment

adrian-wang
adrian-wang reviewed Mar 5, 2015
View reviewed changes
network/shuffle/src/test/java/org/apache/spark/network/shuffle/OneForOneBlockFetcherSuite.java




Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why add this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed empty lines from OneForOneBlockFetcherSuite.java.

@srowen
Copy link
Member

srowen commented Mar 5, 2015

Although I like cleanup, I think we had agreed to not do cross-cutting cleanup like this for its own sake. Anyone else have an opinion on this one?

@srowen
Copy link
Member

srowen commented Mar 6, 2015

OK to test

@srowen
Copy link
Member

srowen commented Mar 6, 2015

ok to test

@SparkQA
Copy link

SparkQA commented Mar 6, 2015

Test build #28340 has started for PR 4900 at commit 5373456.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 6, 2015

Test build #28340 has finished for PR 4900 at commit 5373456.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28340/
Test PASSed.

@asfgit asfgit closed this in dba0b2e Mar 6, 2015
@srowen srowen mentioned this pull request Mar 9, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@vinodkc @AmplabJenkins @srowen @SparkQA @adrian-wang