Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-6211][Streaming] Add Python Kafka API unit test #4961

Closed
wants to merge 15 commits into from

Conversation

jerryshao
Copy link
Contributor

Refactor the Kafka unit test and add Python API support. CC @tdas @davies please help to review, thanks a lot.

@SparkQA
Copy link

SparkQA commented Mar 10, 2015

Test build #28427 has started for PR 4961 at commit d4f2e5b.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 10, 2015

Test build #28427 has finished for PR 4961 at commit d4f2e5b.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class EmbeddedZookeeper(val zkConnect: String)

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28427/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Mar 10, 2015

Test build #28429 has started for PR 4961 at commit 4898694.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 10, 2015

Test build #28429 has finished for PR 4961 at commit 4898694.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class EmbeddedZookeeper(val zkConnect: String)

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28429/
Test FAILed.

@jerryshao
Copy link
Contributor Author

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Mar 10, 2015

Test build #28431 has started for PR 4961 at commit 4898694.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 10, 2015

Test build #28431 has finished for PR 4961 at commit 4898694.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class EmbeddedZookeeper(val zkConnect: String)

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28431/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Mar 11, 2015

Test build #28458 has started for PR 4961 at commit f66a067.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 11, 2015

Test build #28458 has finished for PR 4961 at commit f66a067.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class EmbeddedZookeeper(val zkConnect: String)

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28458/
Test FAILed.

@jerryshao
Copy link
Contributor Author

Looks like maven command in run-tests script do not generate kafka-assembly fat jar, only a single module empty jar. I took a look at the pom file under kafka-assembly, actually has shade plugin and enabled under package, I'm not sure why mvn package from parent module cannot generate kafka-assembly fat jar, only one assembly jar in module assembly is generated, is it a bug or just the right behavior?

Currently what I did is to use mvn -am -pl "external/kafka-assembly" package to generate a fat jar, do you have any suggestions, @tdas. Thanks a lot.

@tdas
Copy link
Contributor

tdas commented Mar 12, 2015

This seems like a bug that was fixed couple of weeks ago. Are you sure you have merged with master recently. In fact the PR has merge conflicts.


/**
* This is a helper class for Kafka test suites. This has the functionality to set up
* and tear down local Kafka servers, and to push data using Kafka producers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add one line to say why this is in /main and not /test.

@tdas
Copy link
Contributor

tdas commented Mar 12, 2015

Other than the assembly issue, its looks quite good. Only a few minor comments.

@jerryshao
Copy link
Contributor Author

Thanks a lot @tdas for your review, actually I rebased the code in my local environment and tried to test again, seems a recent merged PR #3916 changed the behavior of pyspark, so previously --jars argument that can be worked in unit test are failed to work now, I'm trying to figure out a way to enable this in unit test.

@jerryshao
Copy link
Contributor Author

Seems recent merged PR #5261 changed the script and make my test fail, I will fix it.

@SparkQA
Copy link

SparkQA commented Apr 10, 2015

Test build #29999 has started for PR 4961 at commit ee4b919.

@SparkQA
Copy link

SparkQA commented Apr 10, 2015

Test build #29999 has finished for PR 4961 at commit ee4b919.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class FlattenedValuesSerializer(BatchedSerializer):
    • class ExternalList(object):
    • class ExternalListOfList(ExternalList):
    • class GroupByKey(object):
    • class ExternalGroupBy(ExternalMerger):
  • This patch does not change any dependencies.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29999/
Test PASSed.

@jerryshao
Copy link
Contributor Author

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Apr 10, 2015

Test build #30006 has started for PR 4961 at commit ee4b919.

@tdas
Copy link
Contributor

tdas commented Apr 10, 2015

Jenkins, retest this please.
On Apr 9, 2015 6:52 PM, "Apache Spark QA" notifications@github.com wrote:

Test build #29991 has finished
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29991/consoleFull
for PR 4961 at commit 1cda32a
1cda32a
.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.


Reply to this email directly or view it on GitHub
#4961 (comment).

@tdas
Copy link
Contributor

tdas commented Apr 10, 2015

LGTM. Will merge if it passes.

@SparkQA
Copy link

SparkQA commented Apr 10, 2015

Test build #30006 has finished for PR 4961 at commit ee4b919.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30006/
Test PASSed.

@tdas
Copy link
Contributor

tdas commented Apr 10, 2015

Merging this.

@asfgit asfgit closed this in 3290d2d Apr 10, 2015
@tdas
Copy link
Contributor

tdas commented Apr 10, 2015

Thanks @jerryshao for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants