[SPARK-6444] [SQL] A quick fix for SPARK-6444 #5127
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in the JIRA ticket comment, this PR introduces a simple quick fix for SPARK-6444. The root cause of this issue is that we don't check data types of input arguments for SQL functions. PR #4685 is heading the right direction. The reason why moving
PromoteStrings
beforeWidenTypes
fixes this issue is that,PromoteStrings
helpsSum
to check and convert the data type of its argument.