Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-6444] [SQL] A quick fix for SPARK-6444 #5127

Closed
wants to merge 1 commit into from

Conversation

liancheng
Copy link
Contributor

As explained in the JIRA ticket comment, this PR introduces a simple quick fix for SPARK-6444. The root cause of this issue is that we don't check data types of input arguments for SQL functions. PR #4685 is heading the right direction. The reason why moving PromoteStrings before WidenTypes fixes this issue is that, PromoteStrings helps Sum to check and convert the data type of its argument.

Review on Reviewable

@SparkQA
Copy link

SparkQA commented Mar 22, 2015

Test build #28961 has started for PR 5127 at commit cd8f778.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 22, 2015

Test build #28961 timed out for PR 5127 at commit cd8f778 after a configured wait of 120m.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28961/
Test FAILed.

@liancheng
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented Mar 23, 2015

Test build #28995 has started for PR 5127 at commit cd8f778.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 23, 2015

Test build #28995 has finished for PR 5127 at commit cd8f778.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28995/
Test PASSed.

@liancheng
Copy link
Contributor Author

@yhuai Would you mind to take a look? This is the UNION ALL case we've discussed offline the other day. Thanks!

@liancheng
Copy link
Contributor Author

Discussed with @yhuai, we don't want to backport this to branch-1.3 since it's not a regression. So we have plenty of time to deliver a proper fix for this. Closing it.

@liancheng liancheng closed this Mar 25, 2015
@liancheng liancheng deleted the spark-6444-quick-fix branch March 25, 2015 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants