Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-6675][SQL]Hive setConf issue #5457

Closed
wants to merge 3 commits into from
Closed

[SPARK-6675][SQL]Hive setConf issue #5457

wants to merge 3 commits into from

Conversation

gvramana
Copy link
Contributor

Copy of hive configuration to SQLContext Configuration is overwriting the new configurations. So overwriting is disabled to allow newly set configurations to take precedence.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@marmbrus
Copy link
Contributor

ok to test

@SparkQA
Copy link

SparkQA commented Apr 11, 2015

Test build #30092 has started for PR 5457 at commit 76f0400.

@SparkQA
Copy link

SparkQA commented Apr 11, 2015

Test build #30092 has finished for PR 5457 at commit 76f0400.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30092/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Apr 13, 2015

Test build #30165 has started for PR 5457 at commit 6c2ae87.

@SparkQA
Copy link

SparkQA commented Apr 13, 2015

Test build #30165 has finished for PR 5457 at commit 6c2ae87.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30165/
Test PASSed.

@marmbrus
Copy link
Contributor

I think the real problem here is that the initialization of the config is lazy, and if we want to fix this the approach should look like: #3895

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@andrewor14
Copy link
Contributor

@gvramana would you mind closing this PR since it's mostly gone stale? I believe @marmbrus is suggesting a better fix elsewhere.

@yhuai
Copy link
Contributor

yhuai commented Jun 22, 2015

@gvramana Seems SPARK-6675 has been fixed in 1.4 branch and master. Can you close this one?

@gvramana gvramana closed this Jun 23, 2015
asfgit pushed a commit that referenced this pull request Jun 23, 2015
@pwendell
MAINTENANCE: Automated closing of pull requests.
c4d2343 
This commit exists to close the following pull requests on Github:

Closes #2849 (close requested by 'srowen')
Closes #2786 (close requested by 'andrewor14')
Closes #4678 (close requested by 'JoshRosen')
Closes #5457 (close requested by 'andrewor14')
Closes #3346 (close requested by 'andrewor14')
Closes #6518 (close requested by 'andrewor14')
Closes #5403 (close requested by 'pwendell')
Closes #2110 (close requested by 'srowen')
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@gvramana @AmplabJenkins @marmbrus @SparkQA @andrewor14 @yhuai