Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SQL][minor] make it more clear that we only need to re-throw GetField exception for UnresolvedAttribute #5588

Closed
wants to merge 1 commit into from
Closed

[SQL][minor] make it more clear that we only need to re-throw GetField exception for UnresolvedAttribute #5588

wants to merge 1 commit into from

Conversation

cloud-fan
Copy link
Contributor

For GetField outside UnresolvedAttribute, we will throw exception in Analyzer.

@marmbrus
Copy link
Contributor

ok to test

@SparkQA
Copy link

SparkQA commented Apr 21, 2015

Test build #30617 has finished for PR 5588 at commit 7ac74d2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@marmbrus
Copy link
Contributor

Thanks, merged to master.

@asfgit asfgit closed this in 03fd921 Apr 21, 2015
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@cloud-fan @nemccarthy
[SQL][minor] make it more clear that we only need to re-throw GetFiel…
7d6103f 
…d exception for UnresolvedAttribute

For `GetField` outside `UnresolvedAttribute`, we will throw exception in `Analyzer`.

Author: Wenchen Fan <cloud0fan@outlook.com>

Closes apache#5588 from cloud-fan/tmp and squashes the following commits:

7ac74d2 [Wenchen Fan] small refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@cloud-fan @marmbrus @SparkQA