Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor][MLlib] Incorrect path to test data is used in DecisionTreeExample #5594

Closed
wants to merge 2 commits into from
Closed

[Minor][MLlib] Incorrect path to test data is used in DecisionTreeExample #5594

wants to merge 2 commits into from

Conversation

viirya
Copy link
Member

@viirya viirya commented Apr 20, 2015

It should load from testInput instead of input for test data.

@viirya
Copy link
Member Author

viirya commented Apr 20, 2015

cc @jkbradley

@SparkQA
Copy link

SparkQA commented Apr 20, 2015

Test build #30588 has finished for PR 5594 at commit b60b475.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@jkbradley
Copy link
Member

Good catch; thank you! LGTM once tests pass

@SparkQA
Copy link

SparkQA commented Apr 20, 2015

Test build #30591 has finished for PR 5594 at commit 5e8b174.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@jkbradley
Copy link
Member

Merging into master

@asfgit asfgit closed this in 1ebceaa Apr 20, 2015
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@viirya @nemccarthy
[Minor][MLlib] Incorrect path to test data is used in DecisionTreeExa…
20adba9 
…mple

It should load from `testInput` instead of `input` for test data.

Author: Liang-Chi Hsieh <viirya@gmail.com>

Closes apache#5594 from viirya/use_testinput and squashes the following commits:

5e8b174 [Liang-Chi Hsieh] Fix style.
b60b475 [Liang-Chi Hsieh] Use testInput.
@viirya viirya deleted the use_testinput branch December 27, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@viirya @SparkQA @jkbradley