Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor] Comment improvements in ExternalSorter. #5620

Closed
wants to merge 1 commit into from
Closed

[Minor] Comment improvements in ExternalSorter. #5620

wants to merge 1 commit into from

Conversation

pwendell
Copy link
Contributor

  1. Clearly specifies the contract/interactions for users of this class.
  2. Minor fix in one doc to avoid ambiguity.

@pwendell
Copy link
Contributor Author

/cc @andrewor14

@pwendell
[Minor] Comment improvements in ExternalSorter.
8d8f44f 
1. Clearly specifies the contract/interactions for users of this class.
2. Minor fix in one doc to avoid ambiguity.
@pwendell
Copy link
Contributor Author

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Apr 22, 2015

Test build #30707 has finished for PR 5620 at commit 8d8f44f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@sryza
Copy link
Contributor

sryza commented Apr 22, 2015

This LGTM

@pwendell
Copy link
Contributor Author

Thanks for checking this out Sandy, merging it.

@asfgit asfgit closed this in 70f9f8f Apr 22, 2015
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@pwendell @nemccarthy
[MINOR] Comment improvements in ExternalSorter.
35f306c 
1. Clearly specifies the contract/interactions for users of this class.
2. Minor fix in one doc to avoid ambiguity.

Author: Patrick Wendell <patrick@databricks.com>

Closes apache#5620 from pwendell/cleanup and squashes the following commits:

8d8f44f [Patrick Wendell] [Minor] Comment improvements in ExternalSorter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@pwendell @SparkQA @sryza