[SPARK-7163] [SQL] minor refactory for HiveQl #5715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| new this.QueryExecution(plan) | ||
| /* A catalyst metadata catalog that points to the Hive Metastore. */ | ||
| @transient | ||
| override protected[sql] lazy val catalog = new HiveMetastoreCatalog(this) with OverrideCatalog |
There was a problem hiding this comment.
reorder to make catalog, functionRegistry, analyzer, sqlParser togethor
|
Test build #30962 has finished for PR 5715 at commit
|
|
Test build #31353 has finished for PR 5715 at commit
|
|
Test build #31503 has finished for PR 5715 at commit
|
|
We can consider breaking this up, but lets do it after the 1.4 release. Otherwise you are going to cause tons of conflicts with inflight PRs. |
|
yes, after related PR in such as windowfunction we can breaking this up |
|
Can we close this issue until you have time to bring it up to date? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1/5 update:
A work to refactory hiveql to make it more clean and readable
1 move ASTNode related util method to a new object named HiveASTNodeUtil
2 delete no use method in HiveQl
3 override
sqlParserin HiveQLDialec.4 rename HiveQl to HiveQlConverter
The code change seems very big, but actually it's the renaming of HiveQl and extracting some method to HiveASTNodeUtil cause that.
/cc @rxin