Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-6314][CORE] handle JsonParseException for history server #5736

Closed
wants to merge 1 commit into from
Closed

[SPARK-6314][CORE] handle JsonParseException for history server #5736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,8 +333,9 @@ private[history] class FsHistoryProvider(conf: SparkConf) extends ApplicationHis
}
try {
val appListener = new ApplicationEventListener
val maybeTruncated = logPath.getName().endsWith(EventLoggingListener.IN_PROGRESS)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to call isApplicationCompleted(eventLog) instead, to handle legacy logs. (You can then replace the same call a few lines below with the result, to avoid another trip to HDFS.)

bus.addListener(appListener)
bus.replay(logInput, logPath.toString)
bus.replay(logInput, logPath.toString, maybeTruncated)
new FsApplicationHistoryInfo(
logPath.getName(),
appListener.appId.getOrElse(logPath.getName()),
Expand Down