Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-7235] [SQL] Refactor the grouping sets #5780

Closed
wants to merge 2 commits into from

Conversation

chenghao-intel
Copy link
Contributor

The logical plan Expand takes the output as constructor argument, which break the references chain. We need to refactor the code, as well as the column pruning.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented Apr 29, 2015

Test build #31283 has started for PR 5780 at commit c4395b4.

@chenghao-intel
Copy link
Contributor Author

cc @viirya @marmbrus

@SparkQA
Copy link

SparkQA commented Apr 29, 2015

Test build #31283 has finished for PR 5780 at commit c4395b4.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.
  • This patch does not change any dependencies.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31283/
Test FAILed.

@chenghao-intel
Copy link
Contributor Author

The failure depends on #5798

@liancheng
Copy link
Contributor

Hey @chenghao-intel, per our offline discussion, we can fix the case sensitivity issue in a surgical way within this PR (by comparing attribute names in a case insensitivity way when necessary), so that #5798 doesn't bock this one.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented Jun 23, 2015

Test build #35549 has started for PR 5780 at commit 76e4aa4.

@SparkQA
Copy link

SparkQA commented Jun 23, 2015

Test build #35549 has finished for PR 5780 at commit 76e4aa4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class BroadcastHint(child: LogicalPlan) extends UnaryNode

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@marmbrus
Copy link
Contributor

Thanks, this looks a lot cleaner. Merging to master.

@asfgit asfgit closed this in 7b1450b Jun 23, 2015
@chenghao-intel chenghao-intel deleted the expand branch July 2, 2015 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants