-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-7235] [SQL] Refactor the grouping sets #5780
Conversation
Merged build triggered. |
Merged build started. |
Test build #31283 has started for PR 5780 at commit |
Test build #31283 has finished for PR 5780 at commit
|
Merged build finished. Test FAILed. |
Test FAILed. |
The failure depends on #5798 |
Hey @chenghao-intel, per our offline discussion, we can fix the case sensitivity issue in a surgical way within this PR (by comparing attribute names in a case insensitivity way when necessary), so that #5798 doesn't bock this one. |
Merged build triggered. |
Merged build started. |
Test build #35549 has started for PR 5780 at commit |
Test build #35549 has finished for PR 5780 at commit
|
Merged build finished. Test PASSed. |
Thanks, this looks a lot cleaner. Merging to master. |
The logical plan
Expand
takes theoutput
as constructor argument, which break the references chain. We need to refactor the code, as well as the column pruning.